From b23008bc15e19fbb58e51019cb709057a241bff2 Mon Sep 17 00:00:00 2001 From: Thomas von Deyen Date: Fri, 29 Dec 2023 11:35:09 +0100 Subject: [PATCH 1/3] Test with Ruby 3.3 --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4770d64..e7d0494 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,6 +12,7 @@ jobs: - "3.0" - "3.1" - "3.2" + - "3.3" alchemy: - "7.0.0" solidus: From 9776fe17aa6026512a199cd7104c37a2ad621ef9 Mon Sep 17 00:00:00 2001 From: Thomas von Deyen Date: Fri, 29 Dec 2023 11:35:24 +0100 Subject: [PATCH 2/3] Drop Solidus 3.x support Test with Solidus 4.2 as well --- .github/workflows/ci.yml | 2 +- alchemy-solidus.gemspec | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e7d0494..e506a63 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,9 +16,9 @@ jobs: alchemy: - "7.0.0" solidus: - - "3.3" - "4.0" - "4.1" + - "4.2" env: ALCHEMY_VERSION: ${{ matrix.alchemy }} SOLIDUS_VERSION: ${{ matrix.solidus }} diff --git a/alchemy-solidus.gemspec b/alchemy-solidus.gemspec index 3767b50..41521b2 100644 --- a/alchemy-solidus.gemspec +++ b/alchemy-solidus.gemspec @@ -16,8 +16,8 @@ Gem::Specification.new do |gem| gem.version = Alchemy::Solidus::VERSION gem.add_dependency("alchemy_cms", [">= 7.0.0", "< 8"]) - gem.add_dependency("solidus_core", [">= 3.0.0", "< 5"]) - gem.add_dependency("solidus_backend", [">= 3.0.0", "< 5"]) + gem.add_dependency("solidus_core", [">= 4.0.0", "< 5"]) + gem.add_dependency("solidus_backend", [">= 4.0.0", "< 5"]) gem.add_dependency("solidus_support", [">= 0.1.1"]) gem.add_dependency("deface", ["~> 1.0"]) From 19d5d6871b13a1224f8c16a1d553944834d6a1b0 Mon Sep 17 00:00:00 2001 From: Thomas von Deyen Date: Fri, 29 Dec 2023 11:35:54 +0100 Subject: [PATCH 3/3] Do not setup node during tests We do not need node anymore --- .github/workflows/ci.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e506a63..cea0189 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,10 +29,6 @@ jobs: with: ruby-version: ${{ matrix.ruby-version }} bundler-cache: true - - name: Set up Node - uses: actions/setup-node@v3 - with: - node-version: 16 - name: Prepare tests run: bundle exec rake test_setup - name: Run tests