Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocorrelation function #5

Open
ErikOsinga opened this issue Jun 1, 2023 · 1 comment
Open

Add autocorrelation function #5

ErikOsinga opened this issue Jun 1, 2023 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@ErikOsinga
Copy link

Hey Alec,

Very elegant code that's working very well! Given that the computation of pairs and the bookkeeping etc is already there, it would be nice to also add the computation of the autocorrelation function?

Kindly,
Erik
@AlecThomson AlecThomson added enhancement New feature or request question Further information is requested labels Jul 2, 2023
@AlecThomson
Copy link
Owner

Hey @ErikOsinga!

Thanks for the suggestion! I'm curious how the autocorrelation is defined in the structure function / source pair context. What would be the functional form of the ACF in this case?

Also, if you already have it implemented somewhere I'm always happy to receive pull requests ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlecThomson @ErikOsinga