Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl for semver::Version #176

Merged
merged 6 commits into from
Jan 26, 2024
Merged

feat: impl for semver::Version #176

merged 6 commits into from
Jan 26, 2024

Conversation

tymmesyde
Copy link
Contributor

No description provided.

@escritorio-gustavo
Copy link
Contributor

Hey, can you add some tests and fix the merge conflicts?

escritorio-gustavo
escritorio-gustavo reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused about the attributes on your test file

ts-rs/tests/semver.rs Outdated Show resolved Hide resolved
ts-rs/tests/semver.rs Outdated Show resolved Hide resolved
escritorio-gustavo
escritorio-gustavo approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@escritorio-gustavo escritorio-gustavo merged commit 02a1915 into Aleph-Alpha:main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escritorio-gustavo escritorio-gustavo escritorio-gustavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tymmesyde @escritorio-gustavo