Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #308 #309

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Fix #308 #309

merged 9 commits into from
Apr 17, 2024

Conversation

NyxCode
Copy link
Collaborator

@NyxCode NyxCode commented Apr 16, 2024 •
edited
Loading

Goal

Closes #308

Changes

  • Add test
  • Use qualified function calls where they were needed

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@NyxCode NyxCode linked an issue Apr 16, 2024 that may be closed by this pull request
Unqualified call to Self::name() #308
Closed
@NyxCode NyxCode marked this pull request as ready for review April 16, 2024 15:09
escritorio-gustavo
escritorio-gustavo approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Sorry I took so long, had to call in sick yesterday

@escritorio-gustavo escritorio-gustavo merged commit cb1314d into main Apr 17, 2024
14 checks passed
@escritorio-gustavo escritorio-gustavo deleted the issue_308 branch April 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escritorio-gustavo escritorio-gustavo escritorio-gustavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unqualified call to Self::name()
2 participants
@NyxCode @escritorio-gustavo