feat(PNI): include PNI Database #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luabida
commented
Dec 12, 2023
poetry.lock
Outdated
There was a problem hiding this comment.
for some reason, poetry.lock wasn't on repo yet 🤔
luabida
commented
Dec 12, 2023
| @@ -22,7 +22,7 @@ wget = "^3.2" | |||
| loguru = "^0.6.0" | |||
| Unidecode = "^1.3.6" | |||
| dateparser = "^1.1.8" | |||
| pandas = ">=1.5.3" | |||
There was a problem hiding this comment.
pandas 1.5.3 uses applymap instead of map
fccoelho
requested changes
Dec 13, 2023
pysus/ftp/databases/pni.py
Outdated
| ), | ||
| } | ||
| groups = { | ||
| "CPNI": "Centro de Parto Normal Intra-Hospitalar", |
There was a problem hiding this comment.
It's curious that PNI has a dataset for "Parto Normal Intra-Hospitalar", does not seem related...
There was a problem hiding this comment.
By any chance, do you know the difference between CPNI and DPNI? both file prefixes are found in the ftp server
|
@fccoelho This PR needs merge in order to continue AlertaDengue/episcanner-downloader#13 |
fccoelho
approved these changes
Dec 20, 2023
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.