Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A lot of improvements #2

Closed
wants to merge 1 commit into from
Closed

A lot of improvements #2

wants to merge 1 commit into from

Conversation

tihonove
Copy link

  • add tests from original rule
  • add few output test
  • remove code shift usage to make original tests passes (probably jscodeshift modifies AST)
  • fix problem with double messages and incorrect fixing
    due fixer creates two reports it losts lines of code during fixing (in some cases)
  • update package json for using with eslint 4.x

@tihonove
remove code shift usage to make original tests passes
6e2d49b 
fix problem with double messages and incorrect fixing
add tests
update package json for using with eslint 4.x
@tihonove
Copy link
Author

tihonove commented Aug 2, 2017

I make pr to original repo:
import-js/eslint-plugin-import#908

@tihonove tihonove closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tihonove