Merge pull request OpenAtomFoundation#2 from ForestLH/style/clang

Style/clang
AlexStocks · May 25, 2023 · deaa4bb · deaa4bb
2 parents 93b7a0d + 9f902dd
commit deaa4bb
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 7 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -43,6 +43,7 @@ Checks:     '
             -google-runtime-int,
             -clang-diagnostic-unused-command-line-argument,
             -clang-diagnostic-ignored-optimization-argument,
+            -readability-implicit-bool-conversion,
             '
 # CheckOptions:
 #   - { key: readability-identifier-naming.ClassCase,           value: CamelCase  }

diff --git a/src/net/src/backend_thread.cc b/src/net/src/backend_thread.cc
@@ -322,7 +322,7 @@ void BackendThread::ProcessNotifyEvents(const NetFiredEvent* pfe) {
         std::lock_guard l(mu_);
         if (ti.notify_type() == kNotiWrite) {
           if (conns_.find(fd) == conns_.end()) {
-            // TODO: need clean and notify?
+            // TODO(): need clean and notify?
             continue;
           } else {
             // connection exist

diff --git a/src/pika_partition.cc b/src/pika_partition.cc
@@ -16,7 +16,6 @@
 
 using pstd::Status;
 
-extern std::unique_ptr<PikaConf> g_pika_conf;
 extern PikaServer* g_pika_server;
 extern std::unique_ptr<PikaReplicaManager> g_pika_rm;
 

diff --git a/src/pika_repl_client_conn.cc b/src/pika_repl_client_conn.cc
@@ -16,7 +16,6 @@
 
 using pstd::Status;
 
-extern std::unique_ptr<PikaConf> g_pika_conf;
 extern PikaServer* g_pika_server;
 extern std::unique_ptr<PikaReplicaManager> g_pika_rm;
 

diff --git a/src/pstd/include/pstd_status.h b/src/pstd/include/pstd_status.h
@@ -114,7 +114,7 @@ inline void Status::operator=(const Status& s) {
   // and the common case where both s and *this are ok.
   if (state_ != s.state_) {
     delete[] state_;
-    state_ = !s.state_ ? nullptr : CopyStte(s.state_);
+    state_ = !s.state_ ? nullptr : CopyState(s.state_);
   }
 }
 

diff --git a/src/pstd/src/base_conf.cc b/src/pstd/src/base_conf.cc
@@ -21,7 +21,7 @@ static const int kConfItemLen = 1024 * 1024;
 
 BaseConf::BaseConf(const std::string& path) : rep_(std::make_unique<Rep>(path)) {}
 
-BaseConf::~BaseConf() {}
+BaseConf::~BaseConf() = default;
 
 int BaseConf::LoadConf() {
   if (!FileExists(rep_->path)) {

diff --git a/src/pstd/src/posix.cc b/src/pstd/src/posix.cc
@@ -384,7 +384,7 @@ struct hostent* Gethostbyname(const char* name) {
 struct hostent* Gethostbyaddr(const char* addr, int len, int type) {
   struct hostent* p;
 
-  if (!(p = gethostbyaddr(addr, len, type)) {
+  if (!(p = gethostbyaddr(addr, len, type))) {
     LOG(ERROR) << "Gethostbyaddr error: DNS error " << h_errno;
   }
   return p;

diff --git a/src/storage/src/redis_sets.cc b/src/storage/src/redis_sets.cc
@@ -25,7 +25,7 @@ RedisSets::RedisSets(Storage* const s, const DataType& type) : Redis(s, type) {
   spop_counts_store_->SetCapacity(1000);
 }
 
-RedisSets::~RedisSets() {}
+RedisSets::~RedisSets() = default;
 
 rocksdb::Status RedisSets::Open(const StorageOptions& storage_options, const std::string& db_path) {
   statistics_store_->SetCapacity(storage_options.statistics_max_size);