Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from day to night: manual night exposure time does not apply but last day exposure time #443

Closed
vnawrath12159 opened this issue Aug 22, 2021 · 2 comments

Comments

@vnawrath12159
Copy link

Dear developers,

I recently updated (installed) Version 0.8 of this great software package. My setting for capture is as follows:

  • Day Capture: auto-exposure = yes
  • Night Capture: auto-exposure = no / manual setting = 6 seconds
  • Night Capture: auto-gain = yes

I noticed, that when changing from day to night capture, the software doesn't take the nightly auto-exposure manuell setting (6 seconds). Instead it repeats to apply the last exposure time from the day capture. Auto-gain for night is used correctly.

In my opinion, there is a typo in capture.ccp in line 1866:

Instead of
if (numExposures == 0 || **asiDayAutoExposure** == ASI_FALSE)
it should be
if (numExposures == 0 || **asiNightAutoExposure** == ASI_FALSE)

This evening, I will check, whether my manual code change leads to the expected correct change in the exposure time.

Code section for switching to nighttime with the according IF instruction at the end:
` {
sprintf(textBuffer, "==========\n=== Starting nighttime capture ===\n==========\n");
displayDebugText(textBuffer, 0);

        // Setup the night time capture parameters
        if (asiNightAutoExposure == 1)
        {
            currentAutoExposure = ASI_TRUE;
            setControl(CamNum, ASI_AUTO_MAX_EXP, asiNightMaxExposure, ASI_FALSE);
            printf("Saving auto exposed night images with delay of %'d ms (%d sec)\n\n", nightDelay, nightDelay / MS_IN_SEC);
        }
        else
        {
            currentAutoExposure = ASI_FALSE;
            printf("Saving %ds manual exposure night images with delay of %'d ms (%d sec)\n\n", (int)round(currentExposure / US_IN_SEC), nightDelay, nightDelay / MS_IN_SEC);
        }

        currentBrightness = asiNightBrightness;
        currentDelay = nightDelay;
        currentBin = nightBin;
        if (numExposures == 0 || asiDayAutoExposure == ASI_FALSE)
        {
         	currentExposure = asiNightExposure;
        }

`

@EricClaeys
Copy link
Collaborator

I believe you are correct. I probably did a copy/paste from the night-to-day code but didn't change it correctly.
Were you able to change it and see if it worked better?
Eric

@vnawrath12159
Copy link
Author

Yes, after two evenings, the code change worked correctly. The manual night exposure value is now taken when switching from day to night.
Volker

EricClaeys added a commit that referenced this issue Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants