Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh: improved swap handling #2486

Merged
merged 1 commit into from
Mar 26, 2023
Merged

install.sh: improved swap handling #2486

merged 1 commit into from
Mar 26, 2023

Conversation

EricClaeys
Copy link
Collaborator

  • Use "vcgencmd get_config total_mem" if possible to get the actual memory on the Pi. It's very accurate.
  • Set DESIRED_COMBINATION to the amount of physical memory+swap and check against that in a loop. This will be easier to maintain.
  • Handle no swap correctly (0 versus 1 MB).
  • Handle user not removing leading "0" in suggested swap size.
  • Increase max swap if needed.

@EricClaeys
install.sh: improved swap handling
25611b2 
* Use "vcgencmd get_config total_mem" if possible to get the actual memory on the Pi.  It's very accurate.
* Set DESIRED_COMBINATION to the amount of physical memory+swap and check against that in a loop.  This will be easier to maintain.
* Handle no swap correctly (0 versus 1 MB).
* Handle user not removing leading "0" in suggested swap size.
* Increase max swap if needed.
@EricClaeys EricClaeys merged commit ad9057f into dev Mar 26, 2023
@EricClaeys EricClaeys deleted the install.sh-improved-swap-handling branch March 26, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EricClaeys