Modules and overlay editor #2582

…M_CHECKS upload.sh: bug fix with NUM_CHECKS

If there are "a lot" of aborted uploads, let the user know.

…age-on-aborts upload.sh: add System Message on aborts

…nge-ALL-newlines-to-<br> addMessage.sh: bug fix: change ALL newlines

allsky.sh: add missing <code>

We were using "/" for the regex search, but "/" could (and often was) in messages so the sed failed. Use "%" instead (which is not likely to be in a message), but convert it to its ASCII code in the message.

…h-sed addMessage.sh: bug fix with sed

Changes for Suntimes and dates

It's stopped via the Allsky service

Start and stop allskyperiodic with main allsky service

One tester had installation take over 3 hours on a Pi 3b

Move extra directory

Install.sh add debug message

Add date/time formats

* Use "vcgencmd get_config total_mem" if possible to get the actual memory on the Pi. It's very accurate. * Set DESIRED_COMBINATION to the amount of physical memory+swap and check against that in a loop. This will be easier to maintain. * Handle no swap correctly (0 versus 1 MB). * Handle user not removing leading "0" in suggested swap size. * Increase max swap if needed.

…handling install.sh: improved swap handling

…-1000ms-=-1-sec options.json.repo: add (1000ms = 1 sec)

SEVERITY was being used before it was defined.

upload.sh: fix messages

…apse-creation-at-a-time Only allow one mini timelapse creation at a time

* Allows fields to exist in the settings file that aren't displayed but should remain there when other settings are updated. This is done by passing the value as a "hidden" variable. * In the error messages at the top, list more details, like the required fields that are empty. * To help troubleshoot, output "\n\t" on lines so they appear on separate lines in HTML output.

…-not-displayed-settings allskySettings.php: handle not displayed settings

For consistency with other scripts.

for consistency with other scripts

to be consistent with other scripts.

Also, exit with ALLSKY_ERROR_STOP for consistency with other scripts.

Move settings() function

…-settings allsky.html: warn about mini timelapse

It's not needed.

…urn-0 config.sh.repo: remove return 0

It was moved to functions.sh

…tings() config.sh.repo: remove settings()

…ess'-messages addMessage.sh: add 'success'

* Updated PRIOR_ALLSKY_VERSION value * Remove reference to overlay_sample.py which no longer exists. * Replaced some debug "echo" statments with "display_msg debug" * Use "get_version()" instead of hard-coded ".../version". * If the prior Allsky version is being used, get its CAMERA_TYPE. * Bug fix: replace the ALLSKY_VERSION in config files that don't have "XX_ALLSKY_VERSION_XX" which will be the case when upgrading. * Check for missing settings file. * Don't call get_lat_long() (which needs the settings file) if the prior settings file is missing, in which case the new settings file will not be there either. * Bug fix: CONFIG_SH_VERSION was used before set. * Move call to update_config_sh() until after final config.sh file is in place. * Remove "source config.sh" since it's not needed. We use get_variable() when we need a variable in the file.

…s,-plus-improvements install.sh: a few bug fixes, plus improvements

* Combine DATE and TIME into one field - I suspect people will want those fields together. * Remove TEMPERATURE_C - It won't work with RPi cameras which is around half the users. * Start "id" at 0. * Align all fields.

* Combined DATE and TIME fields * Added CAMERA_TYPE and CAMERA_MODEL * Aligned fields

Different font sizes and location since most ZWO cameras are smaller.

…e-Format" overlays.html: format "Time Format"

Depending on what image delay and mini timelapse settings a user has, as well as how fast their Pi is, it's very possible a mini timelapse creation will start before the prior one finishes. Try to detect that possibility.

…s-for-mini-timelapse-settings check_allsky.sh: add checks for mini timelapse

TODO: read the "messages.txt" file using ajax ever page refresh, then every x seconds after that to catch updates, rather than having to add a timestamp to every url.

…e-refreshed-to-update-system-messages index.php: add more timestamps

* Bug fix: "filemtime" returns "false" or the time, not true. * Produce better message when messages file changed. * Bug fix: having timestamp in hidden variable doesn't work; add it to URL.

…cement index.php: bug fix + enhancement

Overlay.json updates

Also, pop up a message to testers and force them to type "yes". This only appears once per "git clone".

It was in install.sh, but was used by several scripts so let's centralize it.

* Use ALLSKY_MODULE_LOCATION. * Use ALLSKY_SCRIPTS instead of ALLSKY_HOME/scripts * Centralize code to get ALLSKY_TMP, ALLSKY_IMAGES, and SETTINGS_FILE. * Moved check for ALLSKY_MODULES to before it's first used.

* Use ALLSKY_MODULE_LOCATION instead of hard-coding path. * Use ALLSKY_SCRIPTS instead of ALLSKY_HOME/scripts.

Copy prior ALLSKY_EXTRA files

Create a file that tells allsky.sh not to display a message since we just did.

If the file exists: if the "_initial_message" file exists, remove it and exit. The next time Allsky starts the user will be reminded to look at the file.

* Use "rm -f" since the files often won't exist; this avoids an error message. * Need to specify full path name to "told" file since we don't know where the user will be when they execute install.sh. * Don't log an error.

…ectory Move installation_log directory

Putting in ALLSKY_TMP doesn't work during installation since it clears out that directory.

variables.sh: change location

Need to determine what it is first.

It's now done in makeChanges.sh so it can also be done when changing camera type in WebUI.

* Require the OLD_VALUE to be specified on the command line. * Use settings() instead of jq. * Move the current overlay.json to the old camera type-specific version, then COPY the new camera type-specific file to overlay.json.

…-makeChanges.sh Pass prior camera type to make changes.sh

…mp() Add "indent=4" to json.dump()

…mestamp-on-URL,-not-in-form allskySettings.php: move _ts

Use new variables

instead of the old name INSTALL_LOGS_DIR

It's also used in allsky.sh

INSTALL_SH_LOG is no longer defined in variables.sh since it's only used in install.sh

It's only used in install.sh

…TALLATION_LOGS Install.sh use ALLSKY_INSTALLATION_LOGS

Split fields.json into system and user files

Also, use ALLSKY_OVERLAY and update the ALLSKY_VERSION variable in config.sh.

…-update-ALLSKY_VERSION install.sh: add more logging

…3.28_tbd Update version to v2023.03.28_tbd

Also, replace "jq -r" with "settings".

…logging install.sh: add even more logging

…r-testers Update install.sh

This is a bug fix

…mem="-from-RAM_SIZE install.sh: remove "total_mem=" from RAM_SIZE

The local and remote configuration.json files (if the Website is installed) need their .config.AllskyVersion setting updated when updating Allsky.

…ration.json's-.AllskyVersion install.sh: add checks

Also: * Create update_locale() to make .locale update since it's called from multiple places. * Add log entries. * Minor comment and indentation changes.

…ocale-if-not-in-settings-file install.sh: add .locale to settings file

…${ALLSKY/Scripts} Update allsky.sh

allsky.sh: add missing $

…ly-copy-file-if-it-exists bug fix: only copy file if it exists

…r-message-if-CAMERA_TYPE-isn't-found Better error message if CAMERA_TYPE isn't defined.

* Display message when CAMERA_TYPE or CAMERA are not defined in a prior config file. This "shouldn't" happen. * Display message when CAMERA_TYPE or ALLSKY_VERSION aren't defined in update_config(). They should be, but they may not have been for one tester.

install.sh: add log messages

…3_31.tbd Update version

* Bug fix: compare PRIOR_FTP_SH_VERSION, not FTP_SH_VERSION. * Improve messages when versions don't match. * Don't include line about looking in post-installation file in the file itself. * Remove big comment about automating conversion from old config files to new one. In the next release the contents of these files will move to settings.json.

* Add timestamp to log file when starting and stopping installation, but don't do if invoking a single function since that's not really an "installation". * Don't recreate the installation logs directory in case a user had to restart installation, e.g., for locale change or if an error. * Couple minor working changes.

Wait until the web server had a chance to start before truncate the file.

Install.sh bug fix plus more

* Minor bug fix: add missing "$". * Don't output our own error message if "cd" fails since lftp outputs a message.

upload.sh: minor bug fix

This requires adding an optional "--websites w" argument to specify whether a local, remote, or both Websites should receive the files.

…ostData.sh postData.sh: allow doing local or remote only

If a valid Website type was specified on the command line then set WEBSITES to that type.

…EBSITES postData.sh: bug fix: set WEBSITES

* Move some initial checks further down so we can log results. * Log most messages.

There's already a variable defined for the name of the directory, so use it.

…BSITE_VIEWSETTINGS_DIRECTORY_NAME use ALLSKY_WEBSITE_VIEWSETTINGS_DIRECTORY_NAME

WEB_CONFIG_FILE is the final location of the configuration.json file, but it's not there yet, so we need to check if the PRIOR config file ($C) is old.

…rror-checking-and-logging Website/install.sh more error checking and logging

* Should exit if upload_data_json_file () fails. * Only call does_prior_Allsky_Website_exist() for local installations.

…es-and-other-minor-changes install.sh: couple bug fixes

An update of Bullseye from Feb 2023 change what's reported from "uname -m". "arm7l" used to be reported for 32-bit OS's and "aarch64" for 64-bit OS's. They now both report "aarch64" if the underlying hardware is 64-bit. We get around this by using "shell dpkg --print-architecture" instead. Also, use "else ifeq ()" when checking the same variable for different values.

Update Makefile

…cation-for-"extra"-directory Use correct location for "extra" directory

* Mark "info" messages with "Info" so it's obvious in the log it's not an error. * Create the default "overlay.json" file since makeChanges.sh couldn't do it since the camera-specific file didn't exist when it was called. * Put the "Testers, ..." code in an "if" statement since it'll stay going forward although the text will changes.

Installation bug fix plus more

For new remote installations there will be no remote_configuration.json file. Fix that but that looked for the file (via upload_data_json_file) before creating it. In the (hopefully rare) case were users are not configuring the remote site via the WebUI, create a dummy remote_configuration.json file.

Fix for manually entering x and y coordinates

Also, only set $remoteWebsiteVersion if not ""

Allow a message to be RETURNED instead of displayed, for those callers who continue despite the message. Also, check for failed read of file.

…e-to-read-remote-Website-config Web UI don't exit if unable to read remote website config

…onfig-file-before-creating-it install.sh: order of use/create remote config file

…changes-to-testers install.sh: minor wording changes to testers

Need to preserve the permissions of the overlay.json file.

…ermissions makeChanges.sh: preserve permissions

Add warning if overlay cannot be saved

…ge is scaled

Fix to remove large black block under the overlay editor

If a setting is empty, use its default if there is one, and warn the user to press the "Save changes" button.

…fault-value-if-not-set allskySettings.php: Use default value if not set

When cropping, stretching, or resizing an image, make the log entry's format consistent: *** ${ME}: some_message

…istent-with-output-msg-formats Update saveImage.sh: use consistent log entry formats

The "convert" command can return a mean with a "e-" format and bc doesn't handle that.

…-means-of-format-1.23e-5 removeBadImages.sh: handle exponential means

Improve error handling if overlay sample fails

$BRANCH doesn't exist yet so use $USER_SPECIFIED_BRANCH in error message.

…laying-bad-BRANCH install.sh: minor bug with BRANCH

Also mention auto-focus cameras.

Give tips on picking a Pi

…riable install.sh: fix typo in variable

Add some checks for empty variables and log if needed.

…re-log-entries website/install.sh: add more log entries

Update version to 2023.05.01

For whatever reason, a tilda at the start of a file/directory name wasn't working so the item wasn't found. Replace tilda with $HOME so it works.

check_allsky.sh: handle tilda

Remove files and environment variables for disabled modules

Plus: * Split reminder message onto multiple lines so it's easer to read. * Don't log when calling a single function so we don't create the installation_logs directory.

…o-run-check_allsky.sh Install.sh remind users to run check allsky.sh

Add default for stroke colour

…re-troubleshooting-for-short-videos timelapse.html: more info on short videos

Error message needs to go to stdout so $VALUE can be set correctly.

…error-to-stdout install.sh: bug fix: write error to stdout

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modules and overlay editor #2582

Modules and overlay editor #2582

Commits on Mar 25, 2023

Commits on Mar 26, 2023

Commits on Mar 27, 2023

Commits on Mar 28, 2023

Commits on Mar 29, 2023

Commits on Mar 30, 2023

Commits on Mar 31, 2023

Commits on Apr 1, 2023

Commits on Apr 2, 2023

Commits on Apr 3, 2023

Commits on Apr 4, 2023

Commits on Apr 11, 2023

Commits on Apr 18, 2023

Commits on Apr 19, 2023

Commits on Apr 22, 2023

Commits on Apr 23, 2023

Commits on Apr 24, 2023

Commits on Apr 25, 2023

Commits on Apr 26, 2023

Commits on Apr 27, 2023

Commits on Apr 30, 2023

Commits on May 1, 2023