Added Amazon S3 support for file uploading in ftp-settings-sh.repo, s… #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aveImageDay.sh, SaveImageNight.sh, endOfNight.sh, timelapse.sh, postData.sh, uploadForDay.sh, README.md. Added asynchronous subshell to all lftp / s3 upload operations as was inconsistently used in some places but not others.
|
Thank you Ian, that's a great contribution to the project. |
|
Sorry just spotted a typo on the subshell forking that I introduced. scripts/saveImageDay.sh, line 60 ends with a '$' when it should end with a '&' as before. I can create a new pull request tomorrow for it, or it might be quicker for you to fix it directly. Mea Culpa. |
|
Good catch! I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aveImageDay.sh, SaveImageNight.sh, endOfNight.sh, timelapse.sh, postData.sh, uploadForDay.sh, README.md.
Added asynchronous subshell to all lftp / s3 upload operations as was inconsistently used in some places but not others.