Fixed # 442 #444
Merged
Fixed # 442 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was accidentally left as "1" from my Pi.
This changes goes with the changes to "allsky-website" that automatically creates video thumbnails. Once people grab the "allsky-website" changes they'll need to create the vidoes/thumnails directory. Should we move the "Create" and "Fixing" code block to a different shell script that users can invoke, and have install.sh also invoke it? That should make it easier for non-technical users to create the directory. The "mkdir" will need to change to "mkdir -p".
Fixes #442 and adds some additional clarifications.
The "free(line);" was causing the problem. I must be misreading the getline() man page where it says to free() the line...
When the "capture" program aborts/crashes (versus gracefully exits), the exit code is (usually?) greater than 100. When that happens, for example due to a bug, there's no reason to let the allsky service restart since the program will crash again, creating an endless cycle. allsky.sh notices when the capture program aborts and displays an "Error" image directing the user to look in the log file and fix the problem. It then stops the service.
thomasjacquin
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md was referring to "settings.json" rather than "settings_ZWO.json" and "settings_RPiHQ.json".