move CFLAGS and DEFS definitions #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, create some generic CFLAGS, with some warnings and optimizations. Do the same for some macros. Then the platform-specific configurations run, appending to CFLAGS, ZWOSDK, and DEFS as appropriate. Finally, combine these into the actual CFLAGS that will be passed to the compiler. Found while wondering why "-O2" wasn't working for me.
thomasjacquin
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, create some generic CFLAGS, with some warnings and optimizations. Do the same for some macros.
Then the platform-specific configurations run, appending to CFLAGS, ZWOSDK, and DEFS as appropriate.
Finally, combine these into the actual CFLAGS that will be passed to the compiler. Found while wondering why "-O2" wasn't working for me.
Also removed
$(COMMON)which wasn't defined anywhere and I suspect was copied from the ZWO SDK example makefile, and added a note to the armv7 section about maybe switching to opencv4.