Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized upload #520

Merged
merged 18 commits into from
Oct 1, 2021
Merged

Centralized upload #520

merged 18 commits into from
Oct 1, 2021

Conversation

EricClaeys
Copy link
Collaborator

Moved all the upload-related code from several files to a new file called "upload.sh". This file can be executed manually, allowing users to debug upload (mostly lftp) issues.

As part of this Pull Request, a new file called "variables.sh" was added that sets several variables used by scripts. For example, ALLSKY_SCRIPTS to point to the allsky/scripts directory, and ALLSKY_TMP to point to allsky/tmp. Having these are variables will allow us to easily move them in the future.

Copy link
Collaborator

@ckuethe ckuethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going. Only one thing I'd like you to fix - the timezone computation, the rest is just style stuff that I don't feel strongly about.

scripts/postData.sh Outdated Show resolved Hide resolved
scripts/generateForDay.sh Outdated Show resolved Hide resolved
scripts/generateForDay.sh Outdated Show resolved Hide resolved
scripts/generateForDay.sh Outdated Show resolved Hide resolved
scripts/generateForDay.sh Outdated Show resolved Hide resolved
scripts/saveImageDay.sh Show resolved Hide resolved
scripts/upload.sh Show resolved Hide resolved
scripts/saveImageDay.sh Show resolved Hide resolved
scripts/upload.sh Show resolved Hide resolved
scripts/upload.sh Show resolved Hide resolved
@ckuethe ckuethe merged commit cd48788 into master Oct 1, 2021
@EricClaeys EricClaeys deleted the CentralizedUpload branch October 1, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants