Have allsky.sh call variables.sh before starting capture #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricClaeys
reviewed
Oct 4, 2021
There was a problem hiding this comment.
Michael, I'm curious why you source's variables.sh near the end of the file rather than right before source $ALLSKY_HOME/config.sh, which is where I have it in my test version. Having it higher means config.sh and most of allsky.sh can use the variables in variables.sh.
Also, before you merge this commit, I'd like to add some minor changes to allsky.sh.
|
Just looked - we really want the call to variables.sh above the call to config.sh since allsky.sh uses $ALLSKY_HOME/scripts that we need to replace with $ALLSKY_SCRIPTS. |
|
@EricClaeys roger that... moved and updated all instances of |
EricClaeys
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows all called scripts from
captureto not need anything fromvariables.sh, thus the multi-loading guard in place invariables.shwill prevent unneeded extra work.