fix usage #723
fix usage #723
Conversation
There was a problem hiding this comment.
Chris, I just added a comment to the Issue about getting a CV error when the output file name doesn't have an extension, e.g., "xxx" versus "xxx.jpg". I just accidently did this.
I suggest having the code check for an extension.
Is the -S option mutually exclusive of the -o and -b options, or can you have all 3? The "|" implies you can't.
|
Chris, I also just noticed I get the line about "Minimum..." if I HAVE |
|
What does the code/help screen say https://github.com/thomasjacquin/allsky/blob/master/src/startrails.cpp#L214 Startrails has always emitted that statistics line, which is desirable for tuning the startrails brightness limit. |
|
I'm going with "don't overcomplicate things." PNG and JPG are by far the most common. |
| std::transform(extcheck.begin(), extcheck.end(), extcheck.begin(), | ||
| [](unsigned char c) { return std::tolower(c); }); | ||
|
|
||
| if (extcheck.rfind(".png") == string::npos || |
There was a problem hiding this comment.
Condition here should be && as the file usually doesn't have both .png and .jpg in it :)
fixes #722