Capture.cpp changes #741
Merged
Capture.cpp changes #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed currentExposure and newExposure
actualExposureMicroseconds asiDayExposure asiNightExposure
asiNightMaxExposure DEFAULT_ASINIGHTMAXEXPOSURE cameraMaxAutoExposureUS
Added asi_day_max_exposure_ms and current_max_exposure_us Moved some code due to adding asi_day_max_exposure
textBuffer -> debug_text and debug levels darkframe -> taking_dark_frames
Merge computeHistogram() into calculateHistogramMean() - they are always called together. Call calculateHistogramMean() from takeOneExposure() to allow better debug statements.
Grabbed the code from PHD2, which states that the ZWO cameras have 2 internal buffers that need to be cleared. I'll remove the old code (which no longer runs) when I'm sure the new code works on different cameras.
and display error message if write of image to disk failed.
Slightly more accurate write time. Includes average write time.
linuxkidd
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the one with only a few commits.
This PR has a bunch of commits, each with fewer changes to make it easier to read.