Image not available when uploading to server

[stefanbrenner]

The current image gets moved into ${WORKING_DIR}/${FULL_FILENAME} before it is uploaded to the server. During the upload the image then cannot be found and an error is thrown.

Solutions

• I just copied (instead of moved) the image away into ${WORKING_DIR}/${FULL_FILENAME}
• another solution would be to set ${IMAGE_TO_USE} to ${WORKING_DIR}/${FULL_FILENAME} but then the timestamp within the filename is lost.

[AndreasLMeg]

@stefanbrenner: Thank you, @EricClaeys should make the review.
(bug since yesterday ? #939 (comment))

[linuxkidd]

thx @stefanbrenner .. appreciate finding and fixing this.

[hpservertech]

Confirmed as working now

[EricClaeys]

@linuxkidd, @AndreasLMeg, @hpservertech, @stefanbrenner
Although doing a cp "${IMAGE_TO_USE}" "${WORKING_DIR}/${FULL_FILENAME}" works, it's not an ideal solution since it executes another cp when only a mv is eventually needed. And since SD cards have a limited number of writes, we're trying to minimize writes.

For the case where daytime images ARE saved, the original code's

mv "${IMAGE_TO_USE}" "${WORKING_DIR}/${FULL_FILENAME}"

worked since the subsequent upload used $FINAL_FILE (the one in allsky/images/DATE).

I'm working on an update to saveImage.sh that will avoid the "cp". When it's ready for testing, I'll let you know.