Skip to content

Fixing repeated instantiation bug #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented May 9, 2025

Description

When running the cypress tests in the signing branch (specifically frontend-test/message.ts), sometimes the instantiation would be cleared early, and thus a later render of InstantiateContainer would trigger another instantiation before the first one had a chance to finish. The result would be that the user got two instances, and frontend crashed when it noticed the mismatch.

This should fix the issue by removing the timing part of this effect. The instantiation is only cleared when the URL changes (i.e. when the user navigates away).

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@olemartinorg olemartinorg added kind/bug Something isn't working backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels May 9, 2025
@olemartinorg olemartinorg moved this to 🔎 Review in Team Apps May 9, 2025
Copy link
Contributor

@HauklandJ HauklandJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented May 9, 2025

@olemartinorg olemartinorg merged commit 2b4dcac into main May 9, 2025
16 of 17 checks passed
@olemartinorg olemartinorg deleted the bug/repeated-instantiation branch May 9, 2025 10:18
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Apps May 9, 2025
@olemartinorg olemartinorg self-assigned this May 12, 2025
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants