Fixing repeated instantiation bug #3347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the cypress tests in the signing branch (specifically
frontend-test/message.ts
), sometimes the instantiation would be cleared early, and thus a later render ofInstantiateContainer
would trigger another instantiation before the first one had a chance to finish. The result would be that the user got two instances, and frontend crashed when it noticed the mismatch.This should fix the issue by removing the timing part of this effect. The instantiation is only cleared when the URL changes (i.e. when the user navigates away).
Related Issue(s)
Verification/QA
kind/*
andbackport*
label to this PR for proper release notes grouping