From baff594806ea10292946e777bcb77a2841467a23 Mon Sep 17 00:00:00 2001
From: Are Almaas <arealmaas@gmail.com>
Date: Wed, 7 Feb 2024 12:57:22 +0100
Subject: [PATCH] ci: remove unused subscriptionid for deployment

---
 .azure/modules/containerAppJob/main.bicep | 4 ++--
 .github/workflows/action-deploy-apps.yml  | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/.azure/modules/containerAppJob/main.bicep b/.azure/modules/containerAppJob/main.bicep
index 12e9c4350..9b05cb8a5 100644
--- a/.azure/modules/containerAppJob/main.bicep
+++ b/.azure/modules/containerAppJob/main.bicep
@@ -16,7 +16,7 @@ resource job 'Microsoft.App/jobs@2023-05-01' = {
       secrets: [
         {
           // todo: move this and refactor into adding this somewhere else
-          name: 'adoconnectionstringsecreturi'
+          name: 'dialogdbconnectionstringsecreturi'
           keyVaultUrl: adoConnectionStringSecretUri
           identity: 'System'
         }
@@ -36,7 +36,7 @@ resource job 'Microsoft.App/jobs@2023-05-01' = {
           env: [
             {
               name: 'Infrastructure__DialogDbConnectionString'
-              secretRef: 'adoconnectionstringsecreturi'
+              secretRef: 'dialogdbconnectionstringsecreturi'
             }
           ]
           image: image
diff --git a/.github/workflows/action-deploy-apps.yml b/.github/workflows/action-deploy-apps.yml
index d78209219..7f93c20fc 100644
--- a/.github/workflows/action-deploy-apps.yml
+++ b/.github/workflows/action-deploy-apps.yml
@@ -79,8 +79,6 @@ jobs:
           scope: resourcegroup
           template: ./.azure/applications/web-api-migration-job/main.bicep
           resourceGroupName: ${{ secrets.AZURE_RESOURCE_GROUP_NAME }}
-          # not needed becauase we sign in with the azure/login action using the subscriptionId
-          subscriptionId: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
           deploymentMode: Incremental
           deploymentName: "dp-be-${{ inputs.environment }}-web-api-migration-job-${{ inputs.gitShortSha }}"
           region: ${{ inputs.region }}
@@ -151,8 +149,6 @@ jobs:
           scope: resourcegroup
           template: ./.azure/applications/${{ matrix.name }}/main.bicep
           resourceGroupName: ${{ secrets.AZURE_RESOURCE_GROUP_NAME }}
-          # not needed becauase we sign in with the azure/login action using the subscriptionId
-          subscriptionId: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
           deploymentMode: Incremental
           deploymentName: dp-be-${{ inputs.environment }}-${{ matrix.name }}-${{ inputs.gitShortSha }}
           region: ${{ inputs.region }}