Pull from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gist: IndexedDB values are currently stored in LevelDB according to the
serialization logic in SerializedScriptValue (SSV). After this CL, an
SSV output that exceeds a threshold gets wrapped in a Blob, and LevelDB
stores a reference to the Blob.
"small" v8::Value -> SSV -> IDBValue (SSV output) -> LevelDB
"large" v8::Value -> SSV -> IDBValue (SSV output) -> Blob w/ SSV output
-> IDBValue (Blob reference) -> LevelDB
On the write side, the IndexedDB (IDB) value serialization logic is
extracted from IDBObjectStore::put() into a separate class,
IDBValueWrapper. This is mostly to avoid further swelling
IDBObjectStore::put(), which is already rather large. IDBValueWrapper
knows how to turn an IDBValue into a SerializedScriptValue (SSV), and
how to wrap the SSV into a Blob, if necessary.
The read-side changes are more complex due to the following:
1) IDB request results are laziliy deserialized from IDBValue, because
the SSV deserialization logic is expensive. The deserialization is done
synchronously, but Blob data can only be fetched asynchronously. So,
IDB values must be unwrapped from Blobs before the SSV logic is
invoked.
2) The events for IDB request results must be dispatched in the order in
which the requests were issued. If an IDB result's SSV requires
Blob-unwrapping, all the following results must be queued until the
Blob is unwrapped and the result's event can be delivered.
The queueing is handled by (sigh) a layer of indirection. Previously,
WebIDBCallbacksImpl called straight into IDBRequest::EnqueueResult().
This CL routes all callbacks that can be queued into
IDBRequest::HandleResult() overloads that match the
IDBRequest::EnqueueResult() signatures. When a result needs to be queued
(either due to Blob-unwrapping, or because it arrives after another
queued result), its data is saved in a IDBRequestQueueItem. These queued
results are tracked by a per-transaction IDBRequestQueue.
When a IDBValue contains a Blob reference, the Blob's content is
asynchronously fetched by IDBRequestLoader. Afterwards,
IDBValueUnwrapper turns the Blob data into an IDBValue that can be
de-serialized by the SerializedScriptValue logic.
BUG=713409
TBR=haraken
Review-Url: https://codereview.chromium.org/2822453003
Cr-Commit-Position: refs/heads/master@{#474874}
We introduce web platform tests for parsing of - offset-position - offset-path - offset-distance - offset-rotate - offset-anchor The unshipped properties offset-position and offset-anchor currently fail a test because we have not yet updated position parsing for a recent CSS Values spec change (see http://crbug.com/717833). offset-rotate currently fails a test because we parse 0 as an angle. This was correct (but leads to shorthand parsing ambiguities) until w3c/csswg-drafts#1162 offset-path fails some tests because we don't yet support url or basic-shape || geometry-box shapes. BUG=722757 Review-Url: https://codereview.chromium.org/2886703002 Cr-Commit-Position: refs/heads/master@{#474881}
Add the [SecureContext] attribute to all of the WebUSB interfaces, so they are not exposed to insecure contexts. This change was dependent on fixing the combination of [OriginTrialEnabled] and [SecureContext], as well as [SecureContext] on interfaces. Bug: 695123 Change-Id: I1aece5c10ffae3e4fafbbb19f10fad5f42c8a312 Reviewed-on: https://chromium-review.googlesource.com/508111 Cr-Commit-Position: refs/heads/master@{#474325} WPT-Export-Revision: 490eee4b140f19216ec28138c7fe89e50aa8bd3b
This breaks most of our layout tests, since most things depend on numbers and lengths, but it's better to be in a single half state than have two half states hanging around. BUG=545318 Review-Url: https://codereview.chromium.org/2867883003 Cr-Commit-Position: refs/heads/master@{#474925}
Currently we have wpt tests verifying Clients.{get,matchAll} can return
clients with type 'window' or 'sharedworker' correctly, this CL adds
support for another type 'worker'.
BUG=705685
TEST=blink_tests
Review-Url: https://codereview.chromium.org/2884843004
Cr-Commit-Position: refs/heads/master@{#474954}
Also update the attribute name to "value" to match the spec, and change the type to a plain String, to avoid interning random developer strings inside AtomicString when we don't need to. In the original spec for Typed OM, every StyleValue subclass was immutable, so you'd need to create new ones if you wanted to udpate something. It turns out that this can be expensive due to garbage collection churn, and it's now been changed so that StyleValue subclasses are mutable. CSSKeywordValue spec (note no "readonly" keyword on value now) https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue BUG=545318 Review-Url: https://codereview.chromium.org/2893823002 Cr-Commit-Position: refs/heads/master@{#474962}
More discussion on whatwg/html#2373 has lead to a shift in the implementation from doing everything at insertion time to updating the internal slot's value at attribute-parse time. This patch updates both the tests and implementation. It should also bring `dromaeo.domcoremodify` back up a bit from the drop we experienced after landing the previous pass at this functionality. Bug: 680419,724099 Change-Id: I93e7880c94889fb8cd04dec5c639fe52105b091a Reviewed-on: https://chromium-review.googlesource.com/517064 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#475014}
BUG=699244 Review-Url: https://codereview.chromium.org/2891403003 Cr-Commit-Position: refs/heads/master@{#475036}
This reverts commit 6ebe242.
Insert extended attributes defined by the specification which were previously omitted. https://w3c.github.io/webappsec-credential-management/#framework-credential-management
**update-served-from-cached** This test asserts caching behavior, but the relevant standards do not explicitly require conformance in this regard. The behavior under test is therefore not generally enforceable in the Web Platform Tests project. Label the test as Chromium-specific and include an in-line comment to document this distinction. **update** This test exists in both WPT and the Chromium project tree. The WPT version is slightly weaker because it accounts for a condition that is not possible according to the latest version of the Service Workers specification [1]. > # Install > > [...] > > 16. Run the Update Registration State algorithm passing registration, > "waiting" and registration’s installing worker as the arguments. > 17. Run the Update Registration State algorithm passing registration, > "installing" and null as the arguments. > 18. Run the Update Worker State algorithm passing registration’s > waiting worker and installed as the arguments. > 19. Invoke Finish Job with job. > 20. Wait for all the tasks queued by Update Worker State invoked in > this algorithm have executed. > 21. Invoke Try Activate with registration. Due to step 20, worker activation does not occur until all prior tasks (which includes microtasks such as the Promise handler microtask created in the test's body) have executed. Remove the conditional logic from the WPT version. Ensure iframe removal takes place regardless of test outcome. Add a 'use strict' directive to script body. Remove unnecessary invocation of `Test#done`. Remove the Chromium version of the test. [1] https://w3c.github.io/ServiceWorker/#installation-algorithm retrieved on 17.05.25 BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2904063003 Cr-Commit-Position: refs/heads/master@{#475294}
**unregister-controller** The Chromium version of this test is equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage (along with its associated "resource" file). **unregister-then-register-new-script** The Chromium version of this test is equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. Remove the associated "resource" file from the Chromium project because it is no longer referenced by any tests. **unregister-then-register** The Chromium version of this test is largely equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. The Chromium includes an additional sub-test, however. Extend the Web Platform Test version with this additional sub-test. Remove an irrelevant comment that describes a possible extension to the test (although the referenced object equality is expected in some contexts, it is not expected in the associated sub-test because the relevant objects are created in distinct JavaScript realms). **unregister** The Chromium version of this test is equivalent to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2904123002 Cr-Commit-Position: refs/heads/master@{#475298}
**skip-waiting-installed** This test exists in both the Web Platform Tests project and in the Chromium project, but the two versions differ slightly. Update the Web Platform Tests version with improvements available in the Chromium version: - Remove unnecessary `<script>` include - Discourage worker termination by invoking `event.waitUntil` - Refactor promise management to avoid timing out in response to assertion failures - Introduce a "use strict" directive The Chromium version contains an additional assertion that is faulty. Extend the Web Platform Tests version with a corrected form of this assertion. Persist the Chromium version in its current state in order to preserve test coverage, but annotate that version with references to a new Chromium issue which tracks the resolution of the underlying bug. **skip-waiting-using-registration** This test exists in equivalent forms in both the Web Platform Tests project and in the Chromium project. Update the Web Platform Tests version: - Remove unnecessary `<script>` include - Refactor promise management to avoid timing out in response to assertion failures - Increase prevision of test "cleanup" logic - Introduce a "use strict" directive Remove the Chromium version of the test. **skip-waiting-without-client** This test exists in equivalent forms in both the Web Platform Tests project and in the Chromium project. Remove an unnecessary `<script>` include from the Web Platform Tests version. Remove the Chromium version of the test. **skip-waiting-without-using-registration** This test exists in equivalent forms in both the Web Platform Tests project and in the Chromium project. Update the Web Platform Tests version: - Remove unnecessary `<script>` include - Increase prevision of test "cleanup" logic - Introduce a "use strict" directive Remove the Chromium version of the test. **skip-waiting** This test exists in equivalent forms in both the Web Platform Tests project and in the Chromium project. Update the Web Platform Tests version: - Remove unnecessary `<script>` include - Increase prevision of test "cleanup" logic - Introduce a "use strict" directive Remove the Chromium version of the test. --- Remove the `skip-waiting-worker.js` "resource" file from the Chromium project as it is no longer referenced by any tests. BUG=688116, 725616 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2900183002 Cr-Commit-Position: refs/heads/master@{#475361}
…selected shipping options. The first fix in the file addresses a test whose intent it to verify that there is no default shippingoption is none were selected, but the actual assert is testing for the wrong value. Looks like a previous copy & paste error. The second set of fixes address tests that are attempting to set the option.select property which doesn't exist. According to the spec, they should be setting the option.selected property.
Fixes a handful of tests dealing with PaymentRequest constructor and …
This patch converts the XHTML tests into HTML5 ones for the Grid Layout suite. The main reason is that HTML5 is the format used for the new tests in this test suite (and generally in WPT) and having 2 different formats in the same suite only causes confusion.
Currently in Chrome, a call to Element.scrollIntoView will calculate the amount each scroller needs to scroll to align the Element as specified and instantly set the scroll position on that scroller (going from the innermost to the outermost scroller). If Element.scrollIntoView is called with scroll-behavior: smooth, instead of scrolling instantly, we should animate to the desired position. We can’t simply call setScrollPosition in PaintLayerScrollableArea and FrameView with ScrollBehaviorSmooth because of the following reasons: - We want to run the animation from the outermost scroller to the innermost scroller - We want to run the animation one after another. That is, the scroll animation on the child scroller should start after the animation on the parent scroller is finished. This patch adds a new class, ProgrammaticScrollCoordinator, that manages programmatic scroll animations. BUG=648446 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2650343008 Cr-Commit-Position: refs/heads/master@{#475387}
…sed on CSSWG call (#6071)
[css-grid] Move test suite to HTML5
The CSS Box Alignment specification has been changed recently so that now all the propeties have the specificed value as computed value. The rationale of this change are at the associated W3C github issue [1]. This change implies that we don't need to execute the StyleAdjuter logic we implemented specifically for supporting 'auto' values resolution for computed style. We can live now with resolution at layout time only. [1] w3c/csswg-drafts#440 BUG=725489 Review-Url: https://codereview.chromium.org/2455093002 Cr-Commit-Position: refs/heads/master@{#475400}
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KaA_YNOlTPk/VmmoV88xBgAJ Bug: 680970 Change-Id: I0aa854521376fd3ae7624b5b4359351709f17b41 Reviewed-on: https://chromium-review.googlesource.com/518156 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#475523} WPT-Export-Revision: 47f72e4c7b6636f1d983c4f3a89fced5e58499d0
**state** This test exists in equivalent forms in both the Web Platform Tests project and in the Chromium project. Remove the Chromium version of the test. **synced-state** This test exists in both WPT and the Chromium project tree. The WPT version is slightly weaker because it accounts for a condition that is not possible according to the latest version of the Service Workers specification [1]. > # Install > > [...] > > 16. Run the Update Registration State algorithm passing registration, > "waiting" and registration’s installing worker as the arguments. > 17. Run the Update Registration State algorithm passing registration, > "installing" and null as the arguments. > 18. Run the Update Worker State algorithm passing registration’s > waiting worker and installed as the arguments. > 19. Invoke Finish Job with job. > 20. Wait for all the tasks queued by Update Worker State invoked in > this algorithm have executed. > 21. Invoke Try Activate with registration. Due to step 20, worker activation does not occur until all prior tasks (which includes microtasks such as the Promise handler microtask created in the test's body) have executed. Remove the conditional logic from the WPT version. Ensure de-registration takes place regardless of test outcome. Ensure failure does not cause test timeout. Add a 'use strict' directive. Remove the Chromium version of the test. [1] https://w3c.github.io/ServiceWorker/#installation-algorithm retrieved on 17.05.24 BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2899343003 Cr-Commit-Position: refs/heads/master@{#475404}
Re-locate test files to Web Platform Test directory for eventual automated upstreaming. The original version of this test registered a handler for the service worker's "install" event after initial evaluation. Because this practice is discouraged by the specification, it should be avoided. Re-factor the test to immediately register the event handler and to preserve the necessary behavior through an explicit message channel with the client. Add a "use strict" directive to script bodies. Introduce a variable declaration for a previously-undeclared binding. Correct a typo in an error message. Ensure that each sub-test's asynchronous "cleanup" logic is complete prior to advancing to the next sub-test. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2906963002 Cr-Commit-Position: refs/heads/master@{#475409}
Spec: https://w3c.github.io/webappsec-csp/embedded/#csp-attribute The 'csp' attribute is supposed to be validated as a serialized-policy and set to null if not a valid one Re-used the existing wpt test that documents this functionality Fixed the expected and actual order in said test as it was reversed BUG=647588 Review-Url: https://codereview.chromium.org/2896833002 Cr-Commit-Position: refs/heads/master@{#475487}
BUG=699244 Review-Url: https://codereview.chromium.org/2889683007 Cr-Commit-Position: refs/heads/master@{#475109}
…h. (patchset #19 id:550001 of https://codereview.chromium.org/2650343008/ ) Reason for revert: Looks this CL made the "WebKit Linux Trusty Leak" bot red. See https://codereview.chromium.org/2650343008/#msg131 Original issue's description: > Implement Element.scrollIntoView for scroll-behavior: smooth. > > Currently in Chrome, a call to Element.scrollIntoView will calculate the amount > each scroller needs to scroll to align the Element as specified and instantly > set the scroll position on that scroller (going from the innermost to the > outermost scroller). > > If Element.scrollIntoView is called with scroll-behavior: smooth, instead of > scrolling instantly, we should animate to the desired position. > > We can’t simply call setScrollPosition in PaintLayerScrollableArea and > FrameView with ScrollBehaviorSmooth because of the following reasons: > - We want to run the animation from the outermost scroller to the > innermost scroller > - We want to run the animation one after another. That is, the scroll animation > on the child scroller should start after the animation on the parent scroller > is finished. > > This patch adds a new class, ProgrammaticScrollCoordinator, that manages > programmatic scroll animations. > > BUG=648446 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2650343008 > Cr-Commit-Position: refs/heads/master@{#475387} > Committed: https://chromium.googlesource.com/chromium/src/+/bbf870d971d95af7ae1ee688a7ed100e3787d02b TBR=jbroman@chromium.org,bokan@chromium.org,ikilpatrick@chromium.org,sigbjornf@opera.com,sunyunjia@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648446 Review-Url: https://codereview.chromium.org/2911103002 Cr-Commit-Position: refs/heads/master@{#475402}
**http-to-https-redirect-and-register** The Web Platform Tests project's infrastructure can only provide secure contexts through the use of the HTTPS protocol. This restriction precludes the strategy used by this test because an HTTPS-origin page cannot load an HTTP-origin iframe. Introduce a related test that may run in the WPT infrastructure: one that creates browsing contexts via `window.open`. Update the surrounding logic to accomodate this alteration. Additionally, update URLs to suitable values for the WPT project, using the `base_path` utility function as per convention there. Because the new version differs substantially, the original version cannot be removed without decreasing test coverage. Persist the original version of the test within the Chromium project, and document the rational for doing so. Update both versions to include "use strict" directives for all script bodies and to avoid including unnecessary script resources. BUG=688116, 522900 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2911073002 Cr-Commit-Position: refs/heads/master@{#475538}
We want to make the pointer lock always take priority over the capture. There are three cases: 1. If we set a pointer lock, at the same time we want to set the pointer capture as well, we should not set pointer capture and send out 'gotpointercapture' event. 2. After we set a pointer lock, we should throw an error when trying to set any pointer capture. 3. If there is a pointer capture and when trying to request a pointer lock, we should release the pointer capture. Testing pages: http://jsbin.com/zasesu/quiet http://jsbin.com/qabopik/quiet http://jsbin.com/fucewup/quiet BUG=697581 Review-Url: https://codereview.chromium.org/2807433003 Cr-Commit-Position: refs/heads/master@{#475572}
We need to consider orthogonality when using the item's logical margin to compute the available space for stretching. The issue this CL fixes is only reproducible when the grid layout logic is executed several times, since probably the item doesn't need to be laid out again. In such cases, we just get the cached logical margins but we were not taking orthogonality into account. Bug: 725903 Change-Id: Id140723dcb8d2cc835598430cf2556ef17228ec3 Reviewed-on: https://chromium-review.googlesource.com/517922 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#475389} WPT-Export-Revision: c57d529a549de5bbea356bbb5a041d835e44f793
Bug: 686927 Change-Id: I428280c1742dde5dc76cb7f0f3c518d66dcb6ef8 Reviewed-on: https://chromium-review.googlesource.com/535085 Cr-Commit-Position: refs/heads/master@{#479878} WPT-Export-Revision: 20f1217a29af6eaaf466fb7969704b99e1d4d046
BUG=699244 Review-Url: https://codereview.chromium.org/2926493002 Cr-Commit-Position: refs/heads/master@{#481536}
This test moves all the tests from third_party/WebKit/LayoutTests/usb to third_party/WebKit/LayoutTests/external/wpt/webusb. The WebUSB Test API polyfill is included in a new resources/chromium directory and loaded automatically when the tests are run in a Chromium-based browser with the --enable-blink-features=MojoJS,MojoJSTest flag set. BUG=705734 Review-Url: https://codereview.chromium.org/2789723003 Cr-Commit-Position: refs/heads/master@{#481732}
[css-ui-3] Add tests for the resize property
To bring in line with spec https://w3c.github.io/web-animations/#the-animationtimeline-interface BUG=624639 Review-Url: https://codereview.chromium.org/2952783002 Cr-Commit-Position: refs/heads/master@{#481800}
* Fix bugs in platform-accessibility-API assertion statements * Fix bugs in test cases (e.g. missing required attribute, typo in id, etc.)
When a service worker is involved, it's possible to get an opaque filtered response for a mode: "cors" request. We peviously checked it in ResourceFetcher but it's insufficient when the resource is shared before the response arrives. This CL instead make a CORS error when we see such response in DocumentThreadableLoader. Bug: 731669, 625575 Change-Id: I65334dbe21c0e2e8aaedd6d5dd5fae762c7cb72c Reviewed-on: https://chromium-review.googlesource.com/527768 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#481863} WPT-Export-Revision: 6d70c3eabfdab9acd9a84e1f94bdf78783bef459
BUG=727173 Change-Id: Idb20e6d81192865d125c802e40ef58ab1960ffbd Reviewed-on: https://chromium-review.googlesource.com/545136 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481806} WPT-Export-Revision: 9b46a24c1db91ac27a049ee289d3606e55573958
Bug: 725654 Change-Id: I51495ca34d641d02bc2f73384900a5bd6b8543a3 Reviewed-on: https://chromium-review.googlesource.com/534456 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#481416}
IDBValueUnwrapper::Unwrap is responsible for creating an IDBValue that
mirrors its input, which is an IDBValue whose SSV data was wrapped in a
Blob. Unfortunately, the old implementation did not carry over the
IDBValue's primary_key_ and key_path_ members. This snuck through
testing because these members are only used when reading values without
explicit primary keys from object stores with key generators (where
autoIncrement is true). In that specific case, the IDBValue's primary
key is injected into the de-serialized V8 value using the IDB's key
path.
Most of this CL is a JavaScript diff restructures the WPT test that covers
serialization/deserialization for IndexedDB valeus that get wrapped in
Blobs. The second large component is a C++ diff that adds
IDBObjectStores to the unit tests for value wrapping, which is necessary
because IDBValues whose primary_key_ is not undefined undergo extra
DCHECKs. The actual bugfix is a few lines of diffs in IDBValue.{h,cpp}
and IDBValueWrapping.cpp.
BUG=735317
Change-Id: Ib303c6d442239833cc537c3d5c1f01a763165eee
Reviewed-on: https://chromium-review.googlesource.com/544543
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481955}
WPT-Export-Revision: 1dab24dfe727d95903ac72dbb86602c1c6f9db5d
…eNavigationTiming. BUG=663175 Review-Url: https://codereview.chromium.org/2932003002 Cr-Commit-Position: refs/heads/master@{#482091}
The spec allows floating-point numbers to start with dot
Added a test for verifying that elements with class names in quirks mode can still be matched by selectors even after their sibling is adopted by a standards mode document. This was a optimization bug that was recently fixed in Chrome. crbug.com/733682
See also https://chromium-review.googlesource.com/c/547019/, and https://crbug.com/736767 for why the automated process failed.
Only content of claim-fetch.https.html needs to be revised. BUG=678905 TEST=blink_tests external/wpt/service-workers/service-worker/claim-fetch.https.html Change-Id: I0efb5298847bb69c0f29bc2dffb1fc51c5a02960 Reviewed-on: https://chromium-review.googlesource.com/544677 Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#481475} WPT-Export-Revision: 0b9e891c68f49faeeb21a5b5d2373fa1bb9f2c8f
This reverts commit 2173679a4a69e4352debd9fee819281592b31240. Reason for revert: We already have test coverage under external/wpt/css/css-writing-mode-3. Original change's description: > Add tests for table/row/row-group directions > > BUG=727173 > > Change-Id: Idb20e6d81192865d125c802e40ef58ab1960ffbd > Reviewed-on: https://chromium-review.googlesource.com/545136 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: David Grogan <dgrogan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481909} TBR=wangxianzhu@chromium.org,dgrogan@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 727173 Change-Id: I011fdc370f549f5337894dae1a5bbed44a88181f Reviewed-on: https://chromium-review.googlesource.com/549058 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#482351} WPT-Export-Revision: 701e6d4fb848230005285f2fa46d37257b89e14b
Renaming `view` to `visualViewport`. This is in response to potential compat impact of `window.view`. See WICG/visual-viewport#42 Bug: 595826 Change-Id: I9a8651cb5e877e2204b5dd84bdba8d423a389806 Reviewed-on: https://chromium-review.googlesource.com/546756 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#482039} WPT-Export-Revision: 67fbc14614b07e96d8be3a199ffb5eb8a8f8b291
Web Share API ED: https://wicg.github.io/web-share/ Note most tests are manual because the API requires user gesture and interaction with user interface.
This CL makes SendBeacon use the standard way to load resources rather than hacky PingLoaderImpl. Bug: 695939 Change-Id: Ice4f09a392337a7920f04f3227177fc8a1681e06 Reviewed-on: https://chromium-review.googlesource.com/541158 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#482552} WPT-Export-Revision: 34416db3a13fc4b409acaad3ba7790fa2a415152
* Add initial test for RTCPeerConnection.prototype.addTrack * Add note that only addTrack checks for duplicate track
…6249) * Add todo coverage comment for addTransceiver * Add test for addTransceiver with MediaStreamTrack * Add note for addTransceiver able to add the same track multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.