Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle blank lines at the end of Karplus data file for jcoupling action #1088

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

drroe
Copy link
Contributor

@drroe drroe commented Jun 26, 2024

6.27.1.

Fixes behavior where CPPTRAJ would segfault if there were blank lines at the end of the Karplus data file in the jcoupling action.

@drroe drroe added the bugfix label Jun 26, 2024
@drroe drroe self-assigned this Jun 26, 2024
@drroe
Copy link
Contributor Author

drroe commented Jun 26, 2024

@hainm any insight into the pytraj error here: https://github.com/Amber-MD/cpptraj/actions/runs/9685730413/job/26726487745?pr=1088

Could it be related to the recent changes? As far as I can tell this change shouldnt affect pytraj at all.

@hainm
Copy link
Contributor

hainm commented Jun 26, 2024 via email

@hainm
Copy link
Contributor

hainm commented Jun 26, 2024

I think it does. (Guess that from reading the title). I will confirm this later (on the way home)).

Oh, my mistake. It's because I did code refactoring and the code uses strenum

I will fix this.

In this pytraj's PR, the tests were run with latest python version. That's why tests didn't fail. Amber-MD/pytraj#1657

@hainm hainm mentioned this pull request Jun 26, 2024
@hainm
Copy link
Contributor

hainm commented Jun 27, 2024

green now

image

@drroe
Copy link
Contributor Author

drroe commented Jun 27, 2024

Thanks Hai!

@drroe drroe merged commit 052878b into Amber-MD:master Jun 27, 2024
13 checks passed
@drroe drroe deleted the jc.segfault branch June 27, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants