Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page #16

Open
Amndeep7 opened this issue Jul 31, 2018 · 9 comments
Open

Settings page #16

Amndeep7 opened this issue Jul 31, 2018 · 9 comments

Comments

@Amndeep7
Copy link
Owner

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Implement_a_settings_page

@Amndeep7
Copy link
Owner Author

Ideas for settings will also be left here as a permanent issue for now I guess

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Aug 19, 2018

Notifications on/off

Should be taken care of by 98040fd

MERGED

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Aug 19, 2018

#15 and the comments within

MERGED: 38cc968

@Amndeep7
Copy link
Owner Author

#11

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Aug 19, 2018

which search engine for #9 if more than one is feasible

As of right now, the only reasonably feasible one is AniList's search in terms of minimal amount of requests needing to be made and size of library

WONTADD

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Aug 19, 2018

#12 - on by default

Should be taken care of by b47b69e for MAL

MERGED: 5b9a7a2

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Aug 22, 2018

On/off setting per list site - all the settings that are site dependent can be dependent on that. Also send notification if site is recognized but site is turned off.

Should be taken care of by 98040fd and 6bfc839

MERGED

Amndeep7 added a commit that referenced this issue Aug 25, 2018
- Reworked mine_url func to be more generalized
- Added more notifications: #22, #16
- Added options global object and updater
- Added options to whether or not a notification is shown: #16
@Amndeep7
Copy link
Owner Author

Amndeep7 commented Sep 2, 2018

Whether or not to add the tab url to the comments box

This is supposed to be the key draw to the extension besides the right-click to add to ptw

WONTADD

Amndeep7 added a commit that referenced this issue Sep 9, 2018
@Amndeep7
Copy link
Owner Author

Amndeep7 commented Sep 19, 2018

Anilist allows custom lists, allow the user to specify which list they want it inserted in, but default to planning/plan to watch/whatever they're calling it

Edit: Looks like you have to have a status/list and then can also put it in 1 or more customlists and if you do so, then you can hide it from the status-lists. Looks like you can also make them private from others. So looks like 3 settings: 1) list of customlist names (drop down list and press a button to make another appear? all of them and then checkboxes?), 2) checkbox for hide from status-lists that's dependent on if any of the customlists are selected, 3) checkbox for privacy

Edit 2:
if you don't have any custom lists, then the hide from status lists checkbox doesn't appear in the list editor popup on the website; if you do have some custom lists, then that hide from status lists checkbox does appear and lets you check it even if you don't add the entry to a custom list; if you then check your profile, that entry is not in any of your lists if you didn't add it to a custom list when you checked the box for hiding them from the status lists
In other words, the website seems kinda buggy in this regard, but the api doesn't have any such dependency issues so all three of the above settings should be completely independent of each other

MERGED: 976cd81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant