Added background color to the Button focus state #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvanmook
approved these changes
Oct 29, 2020
jonkoops
force-pushed
the
feature/updated-buttons-focus-state
branch
from
749d744 to
034b430
Compare
jonkoops
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with DST I’ve updated some Buttons focus state. The focus state on the
primary,secondaryandtertiaryButtons now have the same background-color as the hover. This makes the Button more striking for users that don't have a custom focus outline or focus color.Old primary unfocussed:
Old primary focussed:
New primary focussed:
Old tertiary unfocussed:
Old tertiary focussed:
New tertiary focussed:
