From ff2b7cc448c866dbc5d4b1d6fdecef68c098a37c Mon Sep 17 00:00:00 2001 From: Frederik Petersen Date: Tue, 13 Feb 2024 19:38:39 +0100 Subject: [PATCH] Address pr changes --- coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs b/coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs index b5bc8a47..94c98c2b 100644 --- a/coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs +++ b/coffeecard/CoffeeCard.Library/Services/v2/MenuItemService.cs @@ -80,8 +80,9 @@ public async Task UpdateMenuItemAsync(int id, UpdateMenuItemRe throw new ConflictException($"Menu item already exists with name {changedMenuItem.Name}"); } - if (!changedMenuItem.Active && - await _context.Products.AnyAsync(p => p.EligibleMenuItems.Any(menuItem => menuItem.Id == id))) + + var menuItemIsUsed = await _context.Products.AnyAsync(p => p.EligibleMenuItems.Any(menuItem => menuItem.Id == id)); + if (!changedMenuItem.Active && menuItemIsUsed) { throw new ConflictException("Menu item is in use and cannot be disabled"); }