Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Admin Endpoints #217

Closed
2 of 6 tasks
jonasanker opened this issue Oct 19, 2023 · 1 comment · Fixed by #222 or #233
Closed
2 of 6 tasks

New Admin Endpoints #217

jonasanker opened this issue Oct 19, 2023 · 1 comment · Fixed by #222 or #233
Labels
api-v2 Related to new API version 2

Comments

@jonasanker
Copy link
Member

jonasanker commented Oct 19, 2023 •
edited by HubertWojcik10
Loading

High-level functionality

Suggested API design

POST api/v2/accounts/search
PATCH api/v2/accounts/{id}/user-group

POST api/v2/products
PUT api/v2/products/{id}
DELETE api/v2/products/{id}

POST api/v2/purchases/issue
PUT api/v2/purchases/{id}/refund

POST api/v2/statistics/unused-clips
@jonasanker jonasanker changed the title New Admin Endpoint New Admin Endpoints Oct 19, 2023
@jonasanker jonasanker added the api-v2 Related to new API version 2 label Oct 20, 2023
@HubertWojcik10 HubertWojcik10 linked a pull request Nov 11, 2023 that will close this issue
add a patch endpoint to update a user group of an account #222
Merged
@A-Guldborg
Copy link
Contributor

Products endpoint should include some sort of GET in order to retrieve all products, not filtered based on usergroup or product visibility. For example one of the following:

GET api/v2/products/all (not so restful)
GET api/v2/products?include=all (use query parameter)

This was referenced Dec 1, 2023
Closed
Merged
marfavi added a commit that referenced this issue Dec 12, 2023
@A-Guldborg @marfavi
Adds GET products/all for privileged users (#237)
ee7d26c 
The API adds the endpoint GET /api/v2/products/all, which returns all
products, regardless of usergroup or visibility.

This endpoint will be used for the product management frontend in
AnalogIO/shifty-webapp#20, discussed in
#217 (and slack).

This endpoint is only accessible for users with Board privileges and
will allow board members to manage the visibilty of products or products
that they otherwise don't have access to themselves in the app.

---------

Co-authored-by: Omid Marfavi <21163286+marfavi@users.noreply.github.com>
@jonasanker jonasanker linked a pull request Dec 29, 2023 that will close this issue
217 new admin endpoints: search user #233
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-v2 Related to new API version 2
Projects
None yet
Milestone
No milestone
2 participants
@jonasanker @A-Guldborg