Cleanup of purchase data #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasanker
requested changes
Jul 25, 2023
coffeecard/CoffeeCard.Library/Migrations/20230711144034_AddPurchaseTypes.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Library/Migrations/20230711144034_AddPurchaseTypes.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Library/Migrations/20230711161456_PurchaseDataCleanup.cs
Outdated
Show resolved
Hide resolved
...offeeCard.Library/Migrations/20230714211716_PurchaseOrderIdUniqueAndExternalTransactionId.cs
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
TTA777
force-pushed
the
feature/purchaseDataCleanup
branch
from
1d810c3 to
d2ff9d4
Compare
jonasanker
requested changes
Sep 14, 2023
… to accomodate them
TTA777
force-pushed
the
feature/purchaseDataCleanup
branch
from
d2ff9d4 to
cf90f16
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #190 +/- ##
==========================================
- Coverage 10.23% 8.00% -2.24%
==========================================
Files 147 157 +10
Lines 7708 10007 +2299
Branches 457 458 +1
==========================================
+ Hits 789 801 +12
- Misses 6902 9188 +2286
- Partials 17 18 +1
☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed.
|
jonasanker
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130
The migrations have been tested on a both a local copy of current prd and dev data, and appear to work as intended
Purchase type should also be set in all places where appropriate in the code