Cleanup Products API v2 endpoints #224

jonasanker · 2023-11-12T22:56:21Z

No description provided.

codecov-commenter · 2023-11-12T22:58:02Z

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a5c0c45) 7.90% compared to head (7a6e598) 7.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##           develop    #224      +/-   ##
==========================================
- Coverage     7.90%   7.90%   -0.01%     
==========================================
  Files          163     163              
  Lines        10129   10135       +6     
  Branches       461     461              
==========================================
  Hits           801     801              
- Misses        9310    9316       +6     
  Partials        18      18

Files	Coverage Δ
...ataTransferObjects/v2/Product/AddProductRequest.cs	`0.00% <ø> (ø)`
...TransferObjects/v2/Product/UpdateProductRequest.cs	`0.00% <ø> (ø)`
...ansferObjects/v2/Products/SimpleProductResponse.cs	`0.00% <ø> (ø)`
...nsferObjects/v2/Product/DetailedProductResponse.cs	`0.00% <0.00%> (ø)`
...eeCard.WebApi/Controllers/v2/ProductsController.cs	`0.00% <0.00%> (ø)`
...d/CoffeeCard.Library/Services/v2/ProductService.cs	`15.90% <0.00%> (-0.37%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ghost · 2023-11-12T23:00:49Z

👇 Click on the image for a new way to code review

Legend

jonasanker · 2023-11-12T23:08:18Z

@TTA777, @HubertWojcik10 There were some changes in #215 which I think should be cleaned up thus I have created this PR with these changes. I'm tagging you so you can review them and catch them next time :)
Some of them are possibly opinionated but thougt they were easier to discuss from an example

Highlights

Example should have no space in them
Example should use camelCase as this is how our API formats objects
Patch/Put endpoints should have a path parameter /{id} per REST conventions
Opinionated: Post/Creational endpoint should include the id in the response and return a 201