Expose usergroups on getproducts #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
jonasanker
approved these changes
Nov 30, 2023
duckth
added a commit
that referenced
this pull request
Dec 7, 2023
* add a patch endpoint to update a user group of an account * a fix in xml comments * format code * Exposes setting product user groups to API * fix Jonas comments * authorize only board for the patch endpoint * uncomment the board authorization line * format code * Update documentation examples * Remove obsolete call to get user groups of product * change access to endpoint * Test update product user groups * Removes second call to DB to update user groups * Removes redundant database call * Small fixes to decrease unnecessary code * Remove code smells * Fix last code smell * Add productusergroups to get products (#231) --------- Co-authored-by: Hubert <hubert.wojcik002@gmail.com> Co-authored-by: A-Guldborg <aguh@itu.dk> Co-authored-by: Jonas Anker Rasmussen <jonasanker@gmail.com> Co-authored-by: A-Guldborg <95026056+A-Guldborg@users.noreply.github.com> Co-authored-by: Hubert Wójcik <81220416+HubertWojcik10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MapProductToDto in the productscontroller was missing one line that converts the user groups on a product to usergroups on a ProductResponse.
This allows a frontend to actually see the usergroups on a product.