-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin endpoints for menu items #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added backwards-compatible changes to "use ticket" and "get products" to support the new menu items.
A-Guldborg
added
enhancement
New idea, feature or request
api-v2
Related to new API version 2
labels
Jan 20, 2024
jonasanker
requested changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/AddProductRequest.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/AddProductRequest.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.WebApi/Controllers/v2/MenuItemsController.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.WebApi/Controllers/v2/MenuItemsController.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/UpdateProductRequest.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/UpdateMenuItemRequest.cs
Outdated
Show resolved
Hide resolved
Addresses #248 (comment) Addresses #248 (comment) Addresses #248 (comment) Addresses #248 (comment)
Now uses 403 for when product/menu item exists but not on the user/product respectively Updated documentation Addresses #248 (comment)
Addresses #248 (comment)
A-Guldborg
force-pushed
the
feature/admin/menuitems
branch
from
January 20, 2024 13:22
0ee466f
to
0ec150b
Compare
jonasanker
approved these changes
Jan 21, 2024
Quality Gate failedFailed conditions 20.3% Coverage on New Code (required ≥ 80%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds admin endpoints to #248
It is possible to add, update and read menu items as a board member.
Board members can also specify menu items on products when adding and updating products.
@marfavi consider if you want this in your feature-branch or if this should be merged to main after feature-branch is merged 😄