Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin endpoints for menu items #251

Merged
merged 25 commits into from
Jan 21, 2024
Merged

Admin endpoints for menu items #251

merged 25 commits into from
Jan 21, 2024

Conversation

A-Guldborg
Copy link
Contributor

Adds admin endpoints to #248

It is possible to add, update and read menu items as a board member.

Board members can also specify menu items on products when adding and updating products.

@marfavi consider if you want this in your feature-branch or if this should be merged to main after feature-branch is merged 😄

@A-Guldborg A-Guldborg added enhancement New idea, feature or request api-v2 Related to new API version 2 labels Jan 20, 2024
@A-Guldborg A-Guldborg requested a review from marfavi January 20, 2024 02:00
@ghost
Copy link

ghost commented Jan 20, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested

@A-Guldborg A-Guldborg force-pushed the feature/admin/menuitems branch from 0ee466f to 0ec150b Compare January 20, 2024 13:22
Base automatically changed from feature/menuitems to main January 20, 2024 14:45
@A-Guldborg A-Guldborg requested a review from jonasanker January 21, 2024 12:42
@jonasanker jonasanker enabled auto-merge (squash) January 21, 2024 17:11
Copy link

sonarcloud bot commented Jan 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

20.3% Coverage on New Code (required ≥ 80%)
7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jonasanker jonasanker merged commit 7b13729 into main Jan 21, 2024
5 of 6 checks passed
@jonasanker jonasanker deleted the feature/admin/menuitems branch January 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-v2 Related to new API version 2 enhancement New idea, feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants