Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes unused clips response type to enumerable #278

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

A-Guldborg
Copy link
Contributor

Currently, auto-generated swagger documentation shows only a single response item in the example response value, when the actual result is a JSON array (one element per product type for the given period).

This fix will prevent issues for developers in shifty when generating the API interface.

@A-Guldborg A-Guldborg added bug Verified bug api-v2 Related to new API version 2 labels Apr 15, 2024
@A-Guldborg A-Guldborg self-assigned this Apr 15, 2024
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@A-Guldborg A-Guldborg merged commit abdc835 into main Apr 16, 2024
5 checks passed
@A-Guldborg A-Guldborg deleted the fix/unused-clips-swaggerdocs branch April 16, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-v2 Related to new API version 2 bug Verified bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants