Add support for value-domain.com #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 15, 2021 18:36
adferrand
approved these changes
Dec 28, 2021
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
* Value-Domain added * Apply TTL option * Fix typings to pass against python 3.6 * Fix typings and more for mypy lint check * Format by flake8 * Format test_valuedomain.py by flake8 * Fix comment of test_valuedomain.py * retrigger checks of PR
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
* Value-Domain added * Apply TTL option * Fix typings to pass against python 3.6 * Fix typings and more for mypy lint check * Format by flake8 * Format test_valuedomain.py by flake8 * Fix comment of test_valuedomain.py * retrigger checks of PR
MasinAD
pushed a commit
to MasinAD/lexicon
that referenced
this pull request
Mar 29, 2022
* Value-Domain added * Apply TTL option * Fix typings to pass against python 3.6 * Fix typings and more for mypy lint check * Format by flake8 * Format test_valuedomain.py by flake8 * Fix comment of test_valuedomain.py * retrigger checks of PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear dns-lexicon maintainers,
I would like to send PR to add the support for value-domain.com, a Japanese domain/DNS provider.
Could you please review this PR ?
Best Regards,
Ryoji Kato