Adding LXXLCV versification #11
Conversation
| @@ -150,6 +150,8 @@ John.Short=Ин | |||
| John.Alt=ин,инн | |||
| Acts.Full=Деяния | |||
| Acts.Short=Деян | |||
| Did.Full=Дидахе | |||
There was a problem hiding this comment.
translations are made via Transifex so this will be overwritten. See https://github.com/AndBible/and-bible/wiki/Translating-User-Interface
There was a problem hiding this comment.
Does that mean the code merge not accepted?
There was a problem hiding this comment.
No, it's okay, just saying. But translations need to be done also in transifex.
There was a problem hiding this comment.
So, I think I properly introduced LXXLCV versification in the jsword form, but the system does fail gradle tests.
There was a problem hiding this comment.
What you could do is to try to build AndBible with your version and try it out with your m odule.
There was a problem hiding this comment.
Did you manage to test this?
gradle throws thousand of TEST FAIL errors. I thought it is my clone repo errors, but when I ran
./gradlew teston your repo, same errors appeared.
It looks like CI has been successfull, but not in your branch. Though I have noticed that JSword CI sometimes gives false negatives. https://github.com/AndBible/jsword/actions/runs/4090858645/jobs/7054692044
There was a problem hiding this comment.
Did you manage to test this?
gradle throws thousand of TEST FAIL errors. I thought it is my clone repo errors, but when I ran
./gradlew teston your repo, same errors appeared.It looks like CI has been successfull, but not in your branch. Though I have noticed that JSword CI sometimes gives false negatives. https://github.com/AndBible/jsword/actions/runs/4090858645/jobs/7054692044
What command should I run to test my edits besides running ./gradlew test?
|
Did you manage to test this? |
gradle throws thousand of TEST FAIL errors. |
|
Try If you drop me email I can send you test modules package that is needed to run tests locally. It is automatically installed in CI. |
Updated and installed all dependencies on my Ubuntu machine, ran the Still waiting for your test script. I really want to contribute but I need to set up proper environment. |
|
I emailed you test modules. |
|
How to cancel on my side the failed commit? |
Adding LXXLCV versification where added DID for quick merge test