diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/fragment/FragmentChannelBase.java b/app/src/main/java/com/mxt/anitrend/base/custom/fragment/FragmentChannelBase.java index 28fc891fb..6bbcb0167 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/fragment/FragmentChannelBase.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/fragment/FragmentChannelBase.java @@ -336,7 +336,6 @@ public void onChanged(@Nullable Rss content) { } else showEmpty(getString(R.string.layout_empty_response)); } catch (Exception e) { - e.printStackTrace(); Timber.tag("onChanged(Rss content)").e(e); showEmpty(getString(R.string.layout_empty_response)); } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/sheet/BottomSheetBase.java b/app/src/main/java/com/mxt/anitrend/base/custom/sheet/BottomSheetBase.java index 2f9481f2c..da15178c5 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/sheet/BottomSheetBase.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/sheet/BottomSheetBase.java @@ -70,7 +70,7 @@ public void onStateChanged(@NonNull View bottomSheet, @BottomSheetBehavior.State break; } } catch (Exception e) { - e.printStackTrace(); + Timber.e(e); } } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/ComposerWidget.kt b/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/ComposerWidget.kt index c721a68da..713ee64ae 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/ComposerWidget.kt +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/ComposerWidget.kt @@ -37,6 +37,7 @@ import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.ThreadMode import retrofit2.Call import retrofit2.Response +import timber.log.Timber import java.util.* /** @@ -247,7 +248,7 @@ class ComposerWidget : FrameLayout, CustomView, View.OnClickListener, RetroCallb override fun onFailure(call: Call, throwable: Throwable) { if (lifecycle?.currentState?.isAtLeast(Lifecycle.State.RESUMED) == true) { resetFlipperState() - throwable.printStackTrace() + Timber.e(throwable) throwable.localizedMessage?.let { NotifyUtil.makeText(context, it, Toast.LENGTH_SHORT).show() diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/MarkdownInputEditor.kt b/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/MarkdownInputEditor.kt index 2dc586551..b97b5f92c 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/MarkdownInputEditor.kt +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/editor/MarkdownInputEditor.kt @@ -31,6 +31,7 @@ import io.wax911.emojify.EmojiManager import io.wax911.emojify.parser.parseToHtmlHexadecimal import org.koin.core.component.KoinComponent import org.koin.core.component.inject +import timber.log.Timber /** @@ -306,7 +307,7 @@ class MarkdownInputEditor : TextInputEditText, CustomView, ActionMode.Callback, } inputContentInfo.releasePermission() } catch (e: Exception) { - e.printStackTrace() + Timber.e(e) } return false // return true if succeeded diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/image/WideImageView.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/image/WideImageView.java index 1aa04cdc1..f0c655950 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/image/WideImageView.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/image/WideImageView.java @@ -13,6 +13,8 @@ import com.mxt.anitrend.base.interfaces.view.CustomView; import com.mxt.anitrend.util.KeyUtil; +import timber.log.Timber; + /** * Created by max on 2017/10/30. * 16 x 10 Aspect image view @@ -83,7 +85,7 @@ public static void setImage(WideImageView view, String url) { .apply(RequestOptions.centerCropTransform()) .into(view); } catch (Exception e) { - e.printStackTrace(); + Timber.e(e); } } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AboutPanelWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AboutPanelWidget.java index be42595f7..4c43d8950 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AboutPanelWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AboutPanelWidget.java @@ -129,8 +129,7 @@ public void onResponse(@NonNull Call> call, @NonNull Res @Override public void onFailure(@NonNull Call> call, @NonNull Throwable throwable) { if(isAlive()) { - throwable.printStackTrace(); - Timber.tag(TAG).e(throwable); + Timber.e(throwable); } } }); @@ -198,8 +197,7 @@ public void onResponse(@NonNull Call> call, @NonN @Override public void onFailure(@NonNull Call> call, @NonNull Throwable throwable) { if(isAlive()) { - throwable.printStackTrace(); - Timber.tag(TAG).e(throwable); + Timber.e(throwable); } } }); diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AutoIncrementWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AutoIncrementWidget.java index 6b51a425a..071440a60 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AutoIncrementWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/AutoIncrementWidget.java @@ -133,20 +133,17 @@ public void onResponse(@NonNull Call call, @NonNull Response call, @NonNull Throwable throwable) { try { - Timber.tag(TAG).e(throwable); - throwable.printStackTrace(); + Timber.w(throwable); resetFlipperState(); } catch (Exception e) { - Timber.tag(TAG).e(e); - e.printStackTrace(); + Timber.e(e); } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteToolbarWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteToolbarWidget.java index 642e71beb..168998050 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteToolbarWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteToolbarWidget.java @@ -193,19 +193,17 @@ else if (characterBase != null) NotifyUtil.INSTANCE.makeText(getContext(), R.string.text_error_request, Toast.LENGTH_SHORT).show(); } } catch (Exception e) { - Timber.tag(TAG).w(e); - e.printStackTrace(); + Timber.e(e); } } @Override public void onFailure(@NonNull Call call, @NonNull Throwable throwable) { try { - Timber.tag(TAG).e(throwable); + Timber.w(throwable); resetFlipperState(); } catch (Exception e) { - Timber.tag(TAG).e(e); - e.printStackTrace(); + Timber.e(e); } } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteWidget.java index 23592bbfe..79a6b4c8f 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FavouriteWidget.java @@ -140,8 +140,7 @@ public void onResponse(@NonNull Call> call, @NonNull Response> call, @NonNull Response> call, @NonNull Throwable throwable) { try { - Timber.tag(TAG).e(throwable); + Timber.w(throwable); resetFlipperState(); } catch (Exception e) { - Timber.tag(TAG).e(throwable); - e.printStackTrace(); + Timber.e(throwable); } } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FollowStateWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FollowStateWidget.java index afd285a1b..d8c54abe5 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FollowStateWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/FollowStateWidget.java @@ -140,8 +140,7 @@ public void onResponse(@NonNull Call call, @NonNull Response setControlText(); } } catch (Exception e) { - Timber.tag(TAG).w(e); - e.printStackTrace(); + Timber.e(e); } } @@ -155,11 +154,10 @@ public void onResponse(@NonNull Call call, @NonNull Response @Override public void onFailure(@NonNull Call call, @NonNull Throwable throwable) { try { - throwable.printStackTrace(); + Timber.w(throwable); setControlText(); } catch (Exception e) { - Timber.tag(TAG).e(e); - e.printStackTrace(); + Timber.e(e); } } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ProfileStatsWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ProfileStatsWidget.java index 1c3180521..6cc16e800 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ProfileStatsWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ProfileStatsWidget.java @@ -177,8 +177,7 @@ public void onResponse(@NonNull Call> ca Timber.tag(TAG).w(AniGraphErrorUtilKt.apiError(response)); } } catch (Exception e) { - Timber.tag(TAG).e(e); - e.printStackTrace(); + Timber.e(e); } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ScoreWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ScoreWidget.java index 424093c31..72b5ddd0f 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ScoreWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/ScoreWidget.java @@ -18,6 +18,8 @@ import java.text.ParseException; import java.util.Locale; +import timber.log.Timber; + public class ScoreWidget extends ProgressWidget { private float scoreMaximum, scoreCurrent; @@ -159,7 +161,7 @@ public void afterTextChanged(Editable editable) { try { temporaryValue = !TextUtils.isEmpty(currentChange) ? new DecimalFormat("#.#").parse(currentChange).floatValue() : 0; } catch (ParseException e) { - e.printStackTrace(); + Timber.e(e); } if (scoreFormat.equals(KeyUtil.POINT_10_DECIMAL) && !boundCheck(temporaryValue)) { temporaryValue /= 10; diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusContentWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusContentWidget.java index de4a0bad7..3d31590ac 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusContentWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusContentWidget.java @@ -36,6 +36,8 @@ import java.util.List; import java.util.regex.Matcher; +import timber.log.Timber; + /** * Created by max on 2017/11/25. */ @@ -169,7 +171,7 @@ public void onItemClick(View target, IntPair data) { intent.setData(Uri.parse(data.getSecond())); getContext().startActivity(intent); } catch (ActivityNotFoundException e) { - e.printStackTrace(); + Timber.e(e); } break; } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusDeleteWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusDeleteWidget.java index b85f2067c..2bed1011e 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusDeleteWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/StatusDeleteWidget.java @@ -36,7 +36,6 @@ public class StatusDeleteWidget extends FrameLayout implements CustomView, Retro private @KeyUtil.RequestType int requestType; private FeedList feedList; private FeedReply feedReply; - private final String TAG = StatusDeleteWidget.class.getSimpleName(); public StatusDeleteWidget(Context context) { super(context); @@ -142,10 +141,9 @@ else if (requestType == KeyUtil.MUT_DELETE_FEED_REPLY) } else NotifyUtil.INSTANCE.makeText(getContext(), R.string.text_error_request, Toast.LENGTH_SHORT).show(); } else - Timber.tag(TAG).w(AniGraphErrorUtilKt.apiError(response)); + Timber.w(AniGraphErrorUtilKt.apiError(response)); } catch (Exception e) { - Timber.tag(TAG).w(e); - e.printStackTrace(); + Timber.e(e); } } @@ -159,11 +157,10 @@ else if (requestType == KeyUtil.MUT_DELETE_FEED_REPLY) @Override public void onFailure(@NonNull Call call, @NonNull Throwable throwable) { try { - Timber.tag(TAG).e(throwable.getLocalizedMessage()); - throwable.printStackTrace(); + Timber.w(throwable); resetFlipperState(); } catch (Exception e) { - e.printStackTrace(); + Timber.e(e); } } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/VoteWidget.java b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/VoteWidget.java index 5ca07b773..5e8ca6e61 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/VoteWidget.java +++ b/app/src/main/java/com/mxt/anitrend/base/custom/view/widget/VoteWidget.java @@ -193,8 +193,7 @@ public void onResponse(@NonNull Call call, @NonNull Response res resetFlipperState(); } } catch (Exception e) { - Timber.tag(TAG).w(e); - e.printStackTrace(); + Timber.e(e); } } diff --git a/app/src/main/java/com/mxt/anitrend/base/custom/viewmodel/ViewModelBase.kt b/app/src/main/java/com/mxt/anitrend/base/custom/viewmodel/ViewModelBase.kt index e034da468..e18ae53c6 100644 --- a/app/src/main/java/com/mxt/anitrend/base/custom/viewmodel/ViewModelBase.kt +++ b/app/src/main/java/com/mxt/anitrend/base/custom/viewmodel/ViewModelBase.kt @@ -13,6 +13,7 @@ import com.mxt.anitrend.util.KeyUtil import com.mxt.anitrend.util.graphql.apiError import retrofit2.Call import retrofit2.Response +import timber.log.Timber /** * Created by max on 2017/10/14. @@ -106,6 +107,6 @@ class ViewModelBase: ViewModel(), RetroCallback { */ override fun onFailure(call: Call, throwable: Throwable) { state?.showEmpty(throwable.message ?: errorMessage) - throwable.printStackTrace() + Timber.e(throwable) } } diff --git a/app/src/main/java/com/mxt/anitrend/extension/AppExt.kt b/app/src/main/java/com/mxt/anitrend/extension/AppExt.kt index 2557011a5..ea4a10111 100644 --- a/app/src/main/java/com/mxt/anitrend/extension/AppExt.kt +++ b/app/src/main/java/com/mxt/anitrend/extension/AppExt.kt @@ -45,8 +45,7 @@ fun FragmentActivity.startSharedTransitionActivity(target : View, data : Intent) .makeSceneTransitionAnimation(this, participants) ActivityCompat.startActivity(this, data, transitionActivityOptions.toBundle()) } catch (e: Exception) { - Timber.tag("SharedTransition").w(e) - e.printStackTrace() + Timber.tag("SharedTransition").e(e) } } diff --git a/app/src/main/java/com/mxt/anitrend/model/api/converter/response/AniGraphResponseConverter.kt b/app/src/main/java/com/mxt/anitrend/model/api/converter/response/AniGraphResponseConverter.kt index 43568e7de..abf0a2868 100644 --- a/app/src/main/java/com/mxt/anitrend/model/api/converter/response/AniGraphResponseConverter.kt +++ b/app/src/main/java/com/mxt/anitrend/model/api/converter/response/AniGraphResponseConverter.kt @@ -36,16 +36,11 @@ class AniGraphResponseConverter( targetResult = dataContainer.result } else container?.errors?.forEach { - Timber.tag(TAG).e(it.message) + Timber.e(it.message) } - } catch (ex: Exception) { - ex.printStackTrace() - Timber.tag(TAG).e(ex, jsonResponse?:"Json response is null") + } catch (e: Exception) { + Timber.e(e, jsonResponse?:"Json response is null") } return targetResult } - - companion object { - private val TAG = AniGraphResponseConverter::class.java.simpleName - } } \ No newline at end of file diff --git a/app/src/main/java/com/mxt/anitrend/model/api/retro/WebFactory.kt b/app/src/main/java/com/mxt/anitrend/model/api/retro/WebFactory.kt index 3b1d5bbba..b6a724504 100644 --- a/app/src/main/java/com/mxt/anitrend/model/api/retro/WebFactory.kt +++ b/app/src/main/java/com/mxt/anitrend/model/api/retro/WebFactory.kt @@ -163,9 +163,8 @@ object WebFactory { val response = refreshTokenCall.execute() if (!response.isSuccessful) Timber.tag("requestCodeTokenSync").w(response.apiError()) response.body() - } catch (ex: Exception) { - Timber.tag("requestCodeTokenSync").e(ex) - ex.printStackTrace() + } catch (e: Exception) { + Timber.tag("requestCodeTokenSync").e(e) null } } diff --git a/app/src/main/java/com/mxt/anitrend/util/CompatUtil.kt b/app/src/main/java/com/mxt/anitrend/util/CompatUtil.kt index 27a71e6ed..8152852bc 100644 --- a/app/src/main/java/com/mxt/anitrend/util/CompatUtil.kt +++ b/app/src/main/java/com/mxt/anitrend/util/CompatUtil.kt @@ -30,6 +30,7 @@ import com.mxt.anitrend.extension.getCompatColorAttr import com.mxt.anitrend.util.collection.ComparatorUtil import com.mxt.anitrend.view.activity.base.ImagePreviewActivity import okhttp3.Cache +import timber.log.Timber import java.io.File import java.util.* import kotlin.math.min @@ -67,7 +68,7 @@ object CompatUtil { try { cache = Cache(File(context.cacheDir, "response-cache"), CACHE_LIMIT.toLong()) } catch (e: Exception) { - e.printStackTrace() + Timber.e(e) } return cache diff --git a/app/src/main/java/com/mxt/anitrend/util/DialogUtil.java b/app/src/main/java/com/mxt/anitrend/util/DialogUtil.java index 05b0fabd5..1ccac09c3 100644 --- a/app/src/main/java/com/mxt/anitrend/util/DialogUtil.java +++ b/app/src/main/java/com/mxt/anitrend/util/DialogUtil.java @@ -28,6 +28,8 @@ import java.io.InputStream; import java.util.Collection; +import timber.log.Timber; + /** * Created by max on 2017/09/16. * Creates different dialog types @@ -239,7 +241,7 @@ public static void createChangeLog(Context context) { materialDialog.show(); } catch (IOException e) { - e.printStackTrace(); + Timber.e(e); } } diff --git a/app/src/main/java/com/mxt/anitrend/util/date/DateUtil.kt b/app/src/main/java/com/mxt/anitrend/util/date/DateUtil.kt index 227f56f3f..de14fca58 100644 --- a/app/src/main/java/com/mxt/anitrend/util/date/DateUtil.kt +++ b/app/src/main/java/com/mxt/anitrend/util/date/DateUtil.kt @@ -8,6 +8,7 @@ import com.mxt.anitrend.model.entity.anilist.meta.FuzzyDate import com.mxt.anitrend.util.CompatUtil import com.mxt.anitrend.util.KeyUtil import org.ocpsoft.prettytime.PrettyTime +import timber.log.Timber import java.text.ParseException import java.text.SimpleDateFormat import java.util.* @@ -123,7 +124,7 @@ object DateUtil { calendar.get(Calendar.YEAR)) } catch (e: ParseException) { - e.printStackTrace() + Timber.e(e) } return fuzzyDate.toString() @@ -152,8 +153,8 @@ object DateUtil { try { if (value != 0L) return SimpleDateFormat(dateOutputFormat, Locale.getDefault()).format(Date(value * 1000L)) - } catch (ex: Exception) { - ex.printStackTrace() + } catch (e: Exception) { + Timber.e(e) } return null @@ -173,8 +174,8 @@ object DateUtil { if (converted != null) return SimpleDateFormat(getDateOutputFormat(fuzzyDate), Locale.getDefault()).format(converted) } - } catch (ex: Exception) { - ex.printStackTrace() + } catch (e: Exception) { + Timber.e(e) } return "TBA" @@ -202,7 +203,7 @@ object DateUtil { try { return if (isNewerDate(fuzzyDate)) "Ends" else "Ended" } catch (e: ParseException) { - e.printStackTrace() + Timber.e(e) } return "Ends" @@ -220,7 +221,7 @@ object DateUtil { try { return if (isNewerDate(fuzzyDate)) "Starts" else "Started" } catch (e: ParseException) { - e.printStackTrace() + Timber.e(e) } return "Starts" diff --git a/app/src/main/java/com/mxt/anitrend/util/graphql/AniGraphErrorUtil.kt b/app/src/main/java/com/mxt/anitrend/util/graphql/AniGraphErrorUtil.kt index e7cedbbc2..e1b74bc2c 100644 --- a/app/src/main/java/com/mxt/anitrend/util/graphql/AniGraphErrorUtil.kt +++ b/app/src/main/java/com/mxt/anitrend/util/graphql/AniGraphErrorUtil.kt @@ -32,9 +32,8 @@ fun Response<*>?.apiError(): String { "Too many requests, please retry after $waitPeriod seconds" } } - } catch (ex: Exception) { - ex.printStackTrace() - Timber.tag(TAG).e(ex) + } catch (e: Exception) { + Timber.e(e) return "Unable to recover from encountered error" } diff --git a/app/src/main/java/com/mxt/anitrend/util/markdown/MarkDownUtil.kt b/app/src/main/java/com/mxt/anitrend/util/markdown/MarkDownUtil.kt index 597aaafdf..38f826ce8 100644 --- a/app/src/main/java/com/mxt/anitrend/util/markdown/MarkDownUtil.kt +++ b/app/src/main/java/com/mxt/anitrend/util/markdown/MarkDownUtil.kt @@ -24,7 +24,7 @@ object MarkDownUtil { Html.fromHtml(processedText) } as SpannableStringBuilder } catch (e: Exception) { - e.printStackTrace() + Timber.e(e) SpannableStringBuilder("Unable to process content") } } @@ -44,7 +44,6 @@ object MarkDownUtil { while (result.last() == '\n') result = result.delete(result.lastIndex - 1, result.length) } catch (e: Exception) { - e.printStackTrace() Timber.tag("convert(input)").w(e) } diff --git a/app/src/main/java/com/mxt/anitrend/util/media/MediaActionUtil.java b/app/src/main/java/com/mxt/anitrend/util/media/MediaActionUtil.java index 39ac45042..16a1ff9fe 100644 --- a/app/src/main/java/com/mxt/anitrend/util/media/MediaActionUtil.java +++ b/app/src/main/java/com/mxt/anitrend/util/media/MediaActionUtil.java @@ -79,8 +79,7 @@ private void showActionDialog(@NonNull MediaBase mediaBase) { try { MediaDialogUtil.createSeriesManage(context, mediaBase); } catch (Exception e) { - e.printStackTrace(); - Timber.tag(TAG).e(e.getLocalizedMessage()); + Timber.e(e); } } diff --git a/app/src/main/java/com/mxt/anitrend/util/media/MediaDialogUtil.java b/app/src/main/java/com/mxt/anitrend/util/media/MediaDialogUtil.java index 43a39445e..b29e6ebbc 100644 --- a/app/src/main/java/com/mxt/anitrend/util/media/MediaDialogUtil.java +++ b/app/src/main/java/com/mxt/anitrend/util/media/MediaDialogUtil.java @@ -104,20 +104,18 @@ public void onResponse(@NonNull Call call, @NonNull Response call, @NonNull Throwable throwable) { - throwable.printStackTrace(); + Timber.e(throwable); try { progressDialog.dismiss(); NotifyUtil.INSTANCE.makeText(context, context.getString(R.string.text_error_request), R.drawable.ic_warning_white_18dp, Toast.LENGTH_SHORT).show(); } catch (Exception e) { - Timber.tag(TAG).e(e); - e.printStackTrace(); + Timber.e(e); } } }); @@ -159,20 +157,18 @@ public void onResponse(@NonNull Call call, @NonNull Response call, @NonNull Throwable throwable) { - throwable.printStackTrace(); + Timber.w(throwable); try { progressDialog.dismiss(); NotifyUtil.INSTANCE.makeText(context, context.getString(R.string.text_error_request), R.drawable.ic_warning_white_18dp, Toast.LENGTH_SHORT).show(); } catch (Exception e) { - e.printStackTrace(); - Timber.tag(TAG).e(e); + Timber.e(e); } } }); diff --git a/app/src/main/java/com/mxt/anitrend/view/activity/base/VideoPlayerActivity.java b/app/src/main/java/com/mxt/anitrend/view/activity/base/VideoPlayerActivity.java index cb7e87c61..5a1d692e4 100644 --- a/app/src/main/java/com/mxt/anitrend/view/activity/base/VideoPlayerActivity.java +++ b/app/src/main/java/com/mxt/anitrend/view/activity/base/VideoPlayerActivity.java @@ -20,6 +20,7 @@ import butterknife.ButterKnife; import cn.jzvd.JZDataSource; import cn.jzvd.Jzvd; +import timber.log.Timber; public class VideoPlayerActivity extends ActivityBase implements View.OnClickListener { @@ -60,7 +61,7 @@ public void onBackPressed() { try { player.cancelProgressTimer(); } catch (Exception e) { - e.printStackTrace(); + Timber.e(e); } if(Jzvd.backPress()) { NotifyUtil.INSTANCE.makeText(this, R.string.text_confirm_exit, Toast.LENGTH_SHORT).show(); diff --git a/app/src/main/java/com/mxt/anitrend/view/activity/index/LoginActivity.kt b/app/src/main/java/com/mxt/anitrend/view/activity/index/LoginActivity.kt index ffbf41133..d47a6e679 100644 --- a/app/src/main/java/com/mxt/anitrend/view/activity/index/LoginActivity.kt +++ b/app/src/main/java/com/mxt/anitrend/view/activity/index/LoginActivity.kt @@ -154,8 +154,7 @@ class LoginActivity : ActivityBase(), View.OnClickListener try { startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(WebFactory.API_AUTH_LINK))) } catch (e: Exception) { - e.printStackTrace() - Timber.tag(TAG).e(e.localizedMessage) + Timber.e(e) NotifyUtil.makeText(this, R.string.text_unknown_error, Toast.LENGTH_SHORT).show() } diff --git a/app/src/main/java/com/mxt/anitrend/view/activity/index/MainActivity.kt b/app/src/main/java/com/mxt/anitrend/view/activity/index/MainActivity.kt index aa18d9549..62ccd6301 100644 --- a/app/src/main/java/com/mxt/anitrend/view/activity/index/MainActivity.kt +++ b/app/src/main/java/com/mxt/anitrend/view/activity/index/MainActivity.kt @@ -62,6 +62,7 @@ import kotlinx.coroutines.launch import org.greenrobot.eventbus.EventBus import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.ThreadMode +import timber.log.Timber /** * Created by max on 2017/10/04. @@ -381,7 +382,7 @@ class MainActivity : ActivityBase(), View.OnClickListener, if (permission == Manifest.permission.WRITE_EXTERNAL_STORAGE) onNavigate(R.id.nav_check_update) } catch (e: Exception) { - e.printStackTrace() + Timber.e(e) } } diff --git a/app/src/main/java/com/mxt/anitrend/view/fragment/list/WatchListFragment.java b/app/src/main/java/com/mxt/anitrend/view/fragment/list/WatchListFragment.java index 54b5101b9..c9ddc3f29 100644 --- a/app/src/main/java/com/mxt/anitrend/view/fragment/list/WatchListFragment.java +++ b/app/src/main/java/com/mxt/anitrend/view/fragment/list/WatchListFragment.java @@ -130,8 +130,7 @@ public void onResponse(@NonNull Call>> ca @Override public void onFailure(@NonNull Call>> call, @NonNull Throwable throwable) { if(isAlive()) { - Timber.tag(TAG).w(throwable); - throwable.printStackTrace(); + Timber.w(throwable); } } } diff --git a/app/src/main/java/com/mxt/anitrend/view/fragment/youtube/YouTubeEmbedFragment.java b/app/src/main/java/com/mxt/anitrend/view/fragment/youtube/YouTubeEmbedFragment.java index a6191da20..f831a064b 100644 --- a/app/src/main/java/com/mxt/anitrend/view/fragment/youtube/YouTubeEmbedFragment.java +++ b/app/src/main/java/com/mxt/anitrend/view/fragment/youtube/YouTubeEmbedFragment.java @@ -25,6 +25,7 @@ import com.mxt.anitrend.util.markdown.RegexUtil; import butterknife.ButterKnife; +import timber.log.Timber; public class YouTubeEmbedFragment extends FragmentBase { @@ -106,7 +107,7 @@ public void makeRequest() { intent.setData(Uri.parse(youtubeLink)); startActivity(intent); } catch (ActivityNotFoundException e) { - e.printStackTrace(); + Timber.e(e); NotifyUtil.INSTANCE.makeText(getContext(), R.string.init_youtube_missing, Toast.LENGTH_SHORT).show(); } }); diff --git a/app/src/main/java/com/mxt/anitrend/worker/AuthenticatorWorker.kt b/app/src/main/java/com/mxt/anitrend/worker/AuthenticatorWorker.kt index c982c4f52..0910dcb18 100644 --- a/app/src/main/java/com/mxt/anitrend/worker/AuthenticatorWorker.kt +++ b/app/src/main/java/com/mxt/anitrend/worker/AuthenticatorWorker.kt @@ -2,14 +2,14 @@ package com.mxt.anitrend.worker import android.content.Context import android.net.Uri -import android.text.TextUtils -import androidx.work.* +import androidx.work.CoroutineWorker +import androidx.work.Data +import androidx.work.ListenableWorker +import androidx.work.WorkerParameters import com.mxt.anitrend.BuildConfig import com.mxt.anitrend.base.custom.async.WebTokenRequest import com.mxt.anitrend.presenter.base.BasePresenter import com.mxt.anitrend.util.KeyUtil -import org.koin.core.component.KoinComponent -import org.koin.core.component.inject import timber.log.Timber import java.util.concurrent.ExecutionException @@ -57,10 +57,10 @@ class AuthenticatorWorker( } else Timber.tag(TAG).e("Authorization authenticatorUri was empty or null, cannot authenticate with the current state") } catch (e: ExecutionException) { - e.printStackTrace() + Timber.e(e) errorDataBuilder.putString(KeyUtil.arg_exception_error, e.message) } catch (e: InterruptedException) { - e.printStackTrace() + Timber.e(e) errorDataBuilder.putString(KeyUtil.arg_exception_error, e.message) } diff --git a/app/src/main/java/com/mxt/anitrend/worker/ClearNotificationWorker.kt b/app/src/main/java/com/mxt/anitrend/worker/ClearNotificationWorker.kt index e074eab5e..cc315e0b9 100644 --- a/app/src/main/java/com/mxt/anitrend/worker/ClearNotificationWorker.kt +++ b/app/src/main/java/com/mxt/anitrend/worker/ClearNotificationWorker.kt @@ -60,8 +60,7 @@ class ClearNotificationWorker(context: Context, workerParams: WorkerParameters) } } } catch (e: Exception) { - Timber.tag(TAG).e(e) - e.printStackTrace() + Timber.e(e) } return Result.retry() } diff --git a/app/src/main/java/com/mxt/anitrend/worker/NotificationWorker.kt b/app/src/main/java/com/mxt/anitrend/worker/NotificationWorker.kt index 54049f91a..c72764e06 100644 --- a/app/src/main/java/com/mxt/anitrend/worker/NotificationWorker.kt +++ b/app/src/main/java/com/mxt/anitrend/worker/NotificationWorker.kt @@ -62,7 +62,6 @@ class NotificationWorker( return Result.success() } catch (e: Exception) { Timber.e(e) - e.printStackTrace() } return Result.retry() }