Fix StreamingResponse handling in _resp #792
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: '[PR] Fix StreamingResponse handling in _resp'
labels: 'bug'
assignees: ''
Related Issue
No issue created; this PR directly addresses the bug as per
CONTRIBUTING.mdguidelines.Proposed Changes
This PR fixes a bug where endpoints returning
StreamingResponse(or subclasses) with type annotation caused aTypeError: 'StreamingResponse' object is not iterable.The solution is to short-circuit in
_respand immediately return anyResponsesubclass, regardless of annotation, preventing it from being treated as an iterable.Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply:Additional Information
The fix was made in
00_core.ipynband exported tocore.pyusing nbdev workflow.A notebook cell demonstrates the bug and verifies the fix with a StreamingResponse endpoint and test.
All notebook metadata was cleaned before commit.