Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older nomenclature versions than 3.17.0 #803

Closed
benbelow opened this issue Sep 1, 2022 · 3 comments
Closed

Support older nomenclature versions than 3.17.0 #803

benbelow opened this issue Sep 1, 2022 · 3 comments

Comments

@benbelow
Copy link
Contributor

benbelow commented Sep 1, 2022

In older versions of the HLA nomenclature, certain files in the source data github respoistory do not exist - e.g. https://github.com/ANHIG/IMGTHLA/blob/3170/Allelelist_history.txt is the earliest copy of the Allelelist_history file.

(I haven't confirmed whether this is the only file Atlas uses with this issue - plausibly the minimum version is even higher than 3.17.0)

This change will only be necessary if we need to be able to run Atlas on very old nomenclature versions. One current potential use case is when running match prediction to compare to consensus data, which was derived using nomenclature 3.4.0.

I will run using a later nomenclature and see how the results look - if there are large discrepancies between the consensus and Atlas results, and we believe these can be attributed to the nomenclature version mismatch, we may need to think about how to achieve this.

Otherwise, this may never be worth doing - as realistic use cases of Atlas in production will not need to use any very old nomenclature versions

@benbelow
Copy link
Contributor Author

benbelow commented Sep 1, 2022

If this is not worked on (which I think is likely), then we should instead document somewhere at a high level that Atlas has minimum requirements for HLA nomenclature versions

@benbelow
Copy link
Contributor Author

benbelow commented Sep 1, 2022

Experimentation has shown that 3.33.0 is actually the minimum supported nomenclature

@zabeen
Copy link
Contributor

zabeen commented Sep 24, 2023

No need to support older versions, especially as a new validation dataset is being design by the WMDA Bioinformatics group. Documented instead.

@zabeen zabeen closed this as completed Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants