Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make get_solc_version() method public #153

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

antazoey
Copy link
Member

What I did

I would like to use the get_solc_version() and not worry about it breaking due to it being private.
This PR intends to include the changes needed to accommodate that.

How I did it

  • Remove implementation to method withou underscore
  • Add method with underscore back to point to method without underscore (just in case)

How to verify it

Let me know if it would be ok to make this change.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation (README.md)
  • I have added an entry to the changelog

Copy link
Contributor

@NotPeopling2day NotPeopling2day left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antazoey antazoey merged commit 155a94f into ApeWorX:main Nov 7, 2023
@antazoey antazoey deleted the feat/jules/make-method-public branch November 7, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants