Indicate use of stdin with 0.4.x compiler #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Always include
-
to indicate use of stdin. This wasn't a requirement for compiling until0.5.0
, but it turns out it was always needed when combined withimport_remappings
.Fixes #85
How I did it
In
wrapper.py
, remove the check forand solc_minor >= 5
when deciding if-
should be added.How to verify it
Run the tests. I've added a new case to verify the behavior of
import_remappings
when combined withcompile_source
.