Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All operations under the /admin endpoint should require admin role #4852

Closed
jsenko opened this issue Jul 4, 2024 · 4 comments
Closed

All operations under the /admin endpoint should require admin role #4852

jsenko opened this issue Jul 4, 2024 · 4 comments

Comments

@jsenko
Copy link
Member

jsenko commented Jul 4, 2024

The following operations do not currently follow this principle:

/admin//artifactTypes GET (READ)
/admin/rules GET (READ)
/rules/{rule} GET (READ)

We can either:

  • Simply require the admin role.
  • Move only these operations under the /system endpoint.

For 2.x, this would be a breaking change, but we should change this for 3.x .

@apicurio-bot
Copy link

apicurio-bot bot commented Jul 4, 2024

Thank you for reporting an issue!

Pinging @EricWittmann to respond or triage.

@jsenko
Copy link
Member Author

jsenko commented Jul 4, 2024

Also, we should rename the default OAuth scopes

sr-admin, sr-developer, sr-readonly

to

apicurio-admin, apicurio-developer, apicurio-readonly

@EricWittmann EricWittmann moved this to Backlog in Registry 3.0 Oct 24, 2024
@EricWittmann EricWittmann added this to the 3.0.4 milestone Oct 24, 2024
@EricWittmann
Copy link
Member

Let's also audit the ccompat API to make sure the annotations are correct for access privs.

@EricWittmann
Copy link
Member

Done and done:

Note: we didn't rename the OAuth scopes for 3.0 and at this point it would be a breaking change, so we'll have to live with it as-is.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Registry 3.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants