add ForemanApi

[evgeni]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 91.81818% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.03%. Comparing base (871cd13) to head (c8817e6).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
apypie/foreman.py	91.66%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   90.86%   91.03%   +0.17%     
==========================================
  Files           9       10       +1     
  Lines         449      558     +109     
==========================================
+ Hits          408      508     +100     
- Misses         41       50       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[ekohl]

Partial review, but the train just arrived

[ekohl]

I think my comments are mostly stylistic and overall 👍

Have you thought about documentation? I think we need to add it to https://github.com/Apipie/apypie/blob/master/docs/api.rst for it to be picked up.

[evgeni]

applied your suggestions and added to docs (we don't have docs-build in CI, 😱)

[ehelms]

@ekohl have another look?

[ekohl]

One minor thing, but otherwise 👍

[ekohl]

Can we actually catch this? We use these methods (like cast()) unconditionally so I'd drop the try/except.

[evgeni]

This will never be thrown on Python 3, but the vendoring in FAM breaks if typing stuff is not try'ed, I'll fix that soon, but didn't yet

[evgeni]

#182 is where this will be tackled