diff --git a/bench/Polly.Benchmarks/Polly.Benchmarks.csproj b/bench/Polly.Benchmarks/Polly.Benchmarks.csproj index 5d9d5eb9bf..c7034b11ac 100644 --- a/bench/Polly.Benchmarks/Polly.Benchmarks.csproj +++ b/bench/Polly.Benchmarks/Polly.Benchmarks.csproj @@ -5,7 +5,7 @@ net6.0;net8.0 enable Benchmark - $(NoWarn);CA1822;SA1414;IDE0060 + $(NoWarn);CA1822;IDE0060 diff --git a/src/Polly/Bulkhead/BulkheadSemaphoreFactory.cs b/src/Polly/Bulkhead/BulkheadSemaphoreFactory.cs index 307877dce7..4427c2458c 100644 --- a/src/Polly/Bulkhead/BulkheadSemaphoreFactory.cs +++ b/src/Polly/Bulkhead/BulkheadSemaphoreFactory.cs @@ -3,7 +3,7 @@ namespace Polly.Bulkhead; internal static class BulkheadSemaphoreFactory { - public static (SemaphoreSlim, SemaphoreSlim) CreateBulkheadSemaphores(int maxParallelization, int maxQueueingActions) + public static (SemaphoreSlim MaxParallelizationSemaphore, SemaphoreSlim MaxQueuedActionsSemaphore) CreateBulkheadSemaphores(int maxParallelization, int maxQueueingActions) { var maxParallelizationSemaphore = new SemaphoreSlim(maxParallelization, maxParallelization); diff --git a/src/Polly/Caching/IAsyncCacheProvider.cs b/src/Polly/Caching/IAsyncCacheProvider.cs index d1fddb20a6..e64d2bc09a 100644 --- a/src/Polly/Caching/IAsyncCacheProvider.cs +++ b/src/Polly/Caching/IAsyncCacheProvider.cs @@ -6,6 +6,7 @@ namespace Polly.Caching; /// public interface IAsyncCacheProvider { +#pragma warning disable SA1414 /// /// Gets a value from the cache asynchronously. /// @@ -17,6 +18,7 @@ public interface IAsyncCacheProvider /// the key was found in the cache, and whose second element is the value from the cache (null if not found). /// Task<(bool, object?)> TryGetAsync(string key, CancellationToken cancellationToken, bool continueOnCapturedContext); +#pragma warning restore SA1414 /// /// Puts the specified value in the cache asynchronously. @@ -36,6 +38,7 @@ public interface IAsyncCacheProvider /// The type of the result. public interface IAsyncCacheProvider { +#pragma warning disable SA1414 /// /// Gets a value from the cache asynchronously. /// @@ -47,6 +50,7 @@ public interface IAsyncCacheProvider /// the key was found in the cache, and whose second element is the value from the cache (default(TResult) if not found). /// Task<(bool, TResult?)> TryGetAsync(string key, CancellationToken cancellationToken, bool continueOnCapturedContext); +#pragma warning restore SA1414 /// /// Puts the specified value in the cache asynchronously. diff --git a/src/Polly/Caching/ISyncCacheProvider.cs b/src/Polly/Caching/ISyncCacheProvider.cs index 7c4b87917f..6b6ec09432 100644 --- a/src/Polly/Caching/ISyncCacheProvider.cs +++ b/src/Polly/Caching/ISyncCacheProvider.cs @@ -6,6 +6,7 @@ namespace Polly.Caching; /// public interface ISyncCacheProvider { +#pragma warning disable SA1414 /// /// Gets a value from cache. /// @@ -15,6 +16,7 @@ public interface ISyncCacheProvider /// and whose second element is the value from the cache (null if not found). /// (bool, object?) TryGet(string key); +#pragma warning restore SA1414 /// /// Puts the specified value in the cache. @@ -31,6 +33,7 @@ public interface ISyncCacheProvider /// The type of the result. public interface ISyncCacheProvider { +#pragma warning disable SA1414 /// /// Gets a value from cache. /// @@ -40,6 +43,7 @@ public interface ISyncCacheProvider /// and whose second element is the value from the cache (default(TResult) if not found). /// (bool, TResult?) TryGet(string key); +#pragma warning restore SA1414 /// /// Puts the specified value in the cache. diff --git a/src/Polly/Polly.csproj b/src/Polly/Polly.csproj index 6db80544f8..3f228b6c82 100644 --- a/src/Polly/Polly.csproj +++ b/src/Polly/Polly.csproj @@ -9,7 +9,6 @@ true $(NoWarn);CA1010;CA1031;CA1032;CA1033;CA1051;CA1062;CA1063;CA1064;CA1068;CA1710;CA1716;CA1724;CA1805;CA1815;CA1816;CA2211 $(NoWarn);S2223;S3215;S3246;S3971;S4039;S4049;S4457 - $(NoWarn);SA1414 $(NoWarn);RS0037;