From b106e52b8d7f911374a025958e6ba454f790024a Mon Sep 17 00:00:00 2001
From: Mohammad Zolfaghari <zidom72@gmail.com>
Date: Sun, 6 Aug 2023 14:01:19 +0330
Subject: [PATCH] fix: selection menu respects current node direction

modified insertNodeAfterSelection to copy current node text direction
to the node which is going to get inserteded.

resolves #331
---
 .../format_rich_text_style.dart               |   5 +
 test/service/format_rich_text_style_test.dart | 116 ++++++++++++++++++
 2 files changed, 121 insertions(+)
 create mode 100644 test/service/format_rich_text_style_test.dart

diff --git a/lib/src/service/default_text_operations/format_rich_text_style.dart b/lib/src/service/default_text_operations/format_rich_text_style.dart
index 3b2c1367d..e31eb7e2d 100644
--- a/lib/src/service/default_text_operations/format_rich_text_style.dart
+++ b/lib/src/service/default_text_operations/format_rich_text_style.dart
@@ -48,6 +48,11 @@ bool insertNodeAfterSelection(
   if (currentNode == null) {
     return false;
   }
+  node.updateAttributes({
+    blockComponentTextDirection:
+        currentNode.attributes[blockComponentTextDirection]
+  });
+
   final transaction = editorState.transaction;
   final delta = currentNode.delta;
   if (delta != null && delta.isEmpty) {
diff --git a/test/service/format_rich_text_style_test.dart b/test/service/format_rich_text_style_test.dart
new file mode 100644
index 000000000..3be70ac69
--- /dev/null
+++ b/test/service/format_rich_text_style_test.dart
@@ -0,0 +1,116 @@
+import 'package:appflowy_editor/appflowy_editor.dart';
+import 'package:appflowy_editor/src/service/default_text_operations/format_rich_text_style.dart';
+import 'package:flutter_test/flutter_test.dart';
+import '../new/infra/testable_editor.dart';
+
+void main() async {
+  setUpAll(() {
+    TestWidgetsFlutterBinding.ensureInitialized();
+  });
+
+  group('format rich text style', () {
+    testWidgets('insertNodeAfterSelection', (tester) async {
+      final editor = tester.editor..addParagraph();
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      expect(inserted, true);
+      final node = editor.nodeAtPath([1])!;
+      expect(node.attributes[blockComponentTextDirection], null);
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertNodeAfterSelection on empty node', (tester) async {
+      final editor = tester.editor..addNode(paragraphNode());
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      expect(inserted, true);
+      final node = editor.nodeAtPath([0])!;
+      expect(node.attributes[blockComponentTextDirection], null);
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertNodeAfterSelection on node with text direction',
+        (tester) async {
+      final editor = tester.editor
+        ..addNode(
+          paragraphNode(
+            text: ' ',
+            textDirection: blockComponentTextDirectionAuto,
+          ),
+        );
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      final node = editor.nodeAtPath([1])!;
+      expect(inserted, true);
+      expect(
+        node.attributes[blockComponentTextDirection],
+        blockComponentTextDirectionAuto,
+      );
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertNodeAfterSelection on empty node with text direction',
+        (tester) async {
+      final editor = tester.editor
+        ..addNode(
+          paragraphNode(textDirection: blockComponentTextDirectionLTR),
+        );
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      final node = editor.nodeAtPath([0])!;
+      expect(inserted, true);
+      expect(
+        node.attributes[blockComponentTextDirection],
+        blockComponentTextDirectionLTR,
+      );
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertHeadingAfterSelection on rtl node', (tester) async {
+      final editor = tester.editor
+        ..addNode(
+          paragraphNode(
+            text: ' ',
+            textDirection: blockComponentTextDirectionRTL,
+          ),
+        );
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      insertHeadingAfterSelection(editor.editorState, 1);
+      await tester.pumpAndSettle();
+
+      final node = editor.nodeAtPath([1])!;
+      expect(
+        node.attributes[blockComponentTextDirection],
+        blockComponentTextDirectionRTL,
+      );
+
+      await editor.dispose();
+    });
+  });
+}