From 67321848966a032c6b7ee41b9b62bf865e81729c Mon Sep 17 00:00:00 2001 From: Samuel <36420837+Samueru-sama@users.noreply.github.com> Date: Tue, 6 Aug 2024 23:01:25 -0400 Subject: [PATCH] Use default block size with zstd compression --- src/appimagetool.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/appimagetool.c b/src/appimagetool.c index cf7dd06..c5e56aa 100644 --- a/src/appimagetool.c +++ b/src/appimagetool.c @@ -156,12 +156,13 @@ int sfs_mksquashfs(char *source, char *destination, int offset) { args[i++] = "16384"; } else if (strcmp(sqfs_comp, "zstd") == 0) { /* - * > Build with 1MiB block size - * > Using a bigger block size than mksquashfs's default improves read speed and can produce smaller AppImages as well - * -- https://github.com/probonopd/go-appimage/commit/c4a112e32e8c2c02d1d388c8fa45a9222a529af3 + * > Build with default 128K block size + * > It used to be 1M but that actually causes much higher startup times. + * > Some testing might be needed to see if there is some other value that actually improves performance. + * -- https://github.com/AppImage/appimagetool/issues/64 */ args[i++] = "-b"; - args[i++] = "1M"; + args[i++] = "128K"; } // check if ignore file exists and use it if possible