Bug: OoT Fails Generation with Non-Local Impa's Song

[nicholassaylor]

What happened?

When using non_local_items: ["Everything"], Ocarina of Time will fail as late as possible on fill due to not having a local item.

Looking in the code, it appears that these lines are the culprit:

Archipelago/worlds/oot/Rules.py

Lines 168 to 171 in 4cb8fa3

	if ootworld.shuffle_child_trade == 'skip_child_zelda':
	# Song from Impa must be local
	location = multiworld.get_location('Song from Impa', player)
	add_item_rule(location, lambda item: item.player == player)

What were the expected results?

Ocarina of Time forces a local item on the location since it needs to be local.

Software

Local generation