From feff39cf1fb57c8c78f3c5b556c7de9674d83663 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josip=20Crnkovi=C4=87?= <6536260+crnkovic@users.noreply.github.com> Date: Thu, 16 Nov 2023 12:10:20 +0100 Subject: [PATCH 1/3] Update NftGalleryDraftCard.blocks.tsx --- resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx b/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx index 7f1c6c431..a7250fd34 100644 --- a/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx +++ b/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx @@ -130,7 +130,7 @@ export const NftGalleryDraftStats = ({ currency={user?.attributes.currency ?? "USD"} /> ) : ( - "-" + {t("common.na")} )} From 29b82ecc2d312849ceb570f79d7c6f0d8ad9dad5 Mon Sep 17 00:00:00 2001 From: crnkovic Date: Thu, 16 Nov 2023 11:11:29 +0000 Subject: [PATCH 2/3] style: resolve style guide violations --- resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx b/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx index a7250fd34..674ff77c5 100644 --- a/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx +++ b/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.tsx @@ -130,7 +130,9 @@ export const NftGalleryDraftStats = ({ currency={user?.attributes.currency ?? "USD"} /> ) : ( - {t("common.na")} + + {t("common.na")} + )} From 112695994f41e88f6f598d6f6534e07df8bdcc81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josip=20Crnkovi=C4=87?= <6536260+crnkovic@users.noreply.github.com> Date: Thu, 16 Nov 2023 12:29:15 +0100 Subject: [PATCH 3/3] add test --- .../js/Components/Drafts/NftGalleryDraftCard.blocks.test.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.test.tsx b/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.test.tsx index 0bd7d40d8..478355d5a 100644 --- a/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.test.tsx +++ b/resources/js/Components/Drafts/NftGalleryDraftCard.blocks.test.tsx @@ -157,7 +157,7 @@ describe("NftGalleryDraftStats", () => { expect(screen.getByTestId("NftGalleryDraftStats__nftCount")).toHaveTextContent("0"); }); - it("shoud display - if value is not set", () => { + it("shoud display N/A if value is not set", () => { render( { />, ); - expect(screen.getByTestId("NftGalleryDraftStats__value")).toHaveTextContent("-"); + expect(screen.getByTestId("NftGalleryDraftStats__value")).toHaveTextContent("N/A"); }); it("should display the currency set by the user", () => {