diff --git a/CHANGELOG.md b/CHANGELOG.md index acf3d0eb..45f50f72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Removed ### Fixed +- Parse error in `library_properties.rb` +- Missing include of `IPAddress.h` in `Client.h` ### Security diff --git a/SampleProjects/NetworkLib/test/client.cpp b/SampleProjects/NetworkLib/test/client.cpp new file mode 100644 index 00000000..8e740c34 --- /dev/null +++ b/SampleProjects/NetworkLib/test/client.cpp @@ -0,0 +1,7 @@ +#include +// test for including without +#include + +unittest(test) { assertTrue(true); } + +unittest_main() diff --git a/SampleProjects/TestSomething/library.properties b/SampleProjects/TestSomething/library.properties index 1007bf5f..dba573f5 100644 --- a/SampleProjects/TestSomething/library.properties +++ b/SampleProjects/TestSomething/library.properties @@ -3,8 +3,9 @@ version=0.1.0 author=Ian Katz maintainer=Ian Katz sentence=Arduino CI unit test example -paragraph=A skeleton library demonstrating CI and unit tests +paragraph=A skeleton library demonstrating CI and unit tests. NOTE THAT THE EXTRA BLANK LINE AT THE END OF THIS FILE IS INTENTIONAL TO TEST A PARSE ERROR (#224)! category=Other url=https://github.com/Arduino-CI/arduino_ci/SampleProjects/TestSomething architectures=avr,esp8266 includes=test-something.h + diff --git a/cpp/arduino/Client.h b/cpp/arduino/Client.h index b08e183e..154e618d 100644 --- a/cpp/arduino/Client.h +++ b/cpp/arduino/Client.h @@ -1,6 +1,7 @@ #pragma once #include +#include class Client : public Stream { public: diff --git a/lib/arduino_ci/library_properties.rb b/lib/arduino_ci/library_properties.rb index 1a080713..cc3be974 100644 --- a/lib/arduino_ci/library_properties.rb +++ b/lib/arduino_ci/library_properties.rb @@ -12,7 +12,7 @@ class LibraryProperties def initialize(path) @fields = {} File.foreach(path) do |line| - parts = line.split("=", 2) + parts = line.strip.split("=", 2) # check for empty on next line fails if there is a newline (#224) @fields[parts[0]] = parts[1].chomp unless parts.empty? end end