From 6e16056802c0f4063540a634288a8b89ed5c3d24 Mon Sep 17 00:00:00 2001 From: kalgoop <17824093+kalgoop@users.noreply.github.com> Date: Sat, 22 Dec 2018 00:02:04 +0530 Subject: [PATCH 1/4] fix: maxlength of vendorfield take substring of value in vendorfield, if larger than 64 characters --- lib/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/index.js b/lib/index.js index cd6b948..1c80ea9 100644 --- a/lib/index.js +++ b/lib/index.js @@ -71,7 +71,7 @@ module.exports = class ArkPay extends Emittery { * @return {ArkPay} */ vendorField (value) { - this.data.transfer.vendorField = value + this.data.transfer.vendorField = value.substring(0,64) return this } From 6c78612df9c98cb32937026cded21fe8add867be Mon Sep 17 00:00:00 2001 From: kalgoop <17824093+kalgoop@users.noreply.github.com> Date: Sat, 22 Dec 2018 11:30:55 +0530 Subject: [PATCH 2/4] revert fix: maxlength of vendorfield --- lib/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/index.js b/lib/index.js index 1c80ea9..cd6b948 100644 --- a/lib/index.js +++ b/lib/index.js @@ -71,7 +71,7 @@ module.exports = class ArkPay extends Emittery { * @return {ArkPay} */ vendorField (value) { - this.data.transfer.vendorField = value.substring(0,64) + this.data.transfer.vendorField = value return this } From babe8c7f60e4ca402538ece8f62cd8c309089443 Mon Sep 17 00:00:00 2001 From: kalgoop <17824093+kalgoop@users.noreply.github.com> Date: Sat, 22 Dec 2018 11:38:04 +0530 Subject: [PATCH 3/4] emit error when vendorfield.length > 64 --- lib/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/index.js b/lib/index.js index cd6b948..5636190 100644 --- a/lib/index.js +++ b/lib/index.js @@ -72,6 +72,8 @@ module.exports = class ArkPay extends Emittery { */ vendorField (value) { this.data.transfer.vendorField = value + + if (value.length > 64) this.emit('error', 'Value in venderfield is too long') return this } From 889d809ca7c3b21bbe08f2328b8acd45ad4f7193 Mon Sep 17 00:00:00 2001 From: kalgoop <17824093+kalgoop@users.noreply.github.com> Date: Sat, 22 Dec 2018 11:49:53 +0530 Subject: [PATCH 4/4] throw error when vendorfield.length>64 --- lib/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/index.js b/lib/index.js index 5636190..ecad018 100644 --- a/lib/index.js +++ b/lib/index.js @@ -73,7 +73,7 @@ module.exports = class ArkPay extends Emittery { vendorField (value) { this.data.transfer.vendorField = value - if (value.length > 64) this.emit('error', 'Value in venderfield is too long') + if (value.length > 64) throw new Error('The given value exceeds the maximum length of 64 characters.') return this }