Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework glucose dialog #272

Merged
merged 12 commits into from
Oct 27, 2023
Merged

Rework glucose dialog #272

merged 12 commits into from
Oct 27, 2023

Commits on Oct 22, 2023

  1. Rework glucose dialog 

    * Refactor manual glucose entry from popup to sheet-based dialog
* Adds delete dialog to glucose entries, i.e., streamlining it to how treatments are deleted
* Small refactoring for DateTableStateModel: pass glucose object instead of index on deletion
* Change "Add" button to proper button with text and icon above list
    @dnzxy
    dnzxy committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0b54e78 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Add changes after PR revisions 

    * Pull in latest dev
* Remove glucose deletion alert
* Change button styling and layout: button now situated in header row of list
* Add header row label "time" for the left "column" of the displayed text in list
    @dnzxy
    dnzxy committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    48a4862 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Fix button color to use Color.accentColor instead of wrongly commit… 

    …ed `Color.gray` color
    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b09080f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into rework-glucose-dialog

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0d2bb0e View commit details
    Browse the repository at this point in the history

  3. Remove unit from list; add unit as button text

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f3573bc View commit details
    Browse the repository at this point in the history

  4. Revert all additions other than removing popup and adding entry dialog

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    e3f18cb View commit details
    Browse the repository at this point in the history

  5. Remove lines from Jons comment

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    222c363 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary empty line

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    468662a View commit details
    Browse the repository at this point in the history

  7. Remove hardcoded limits and only validate negative numbers

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f459559 View commit details
    Browse the repository at this point in the history

  8. Some changes 

    * Add back in reasonable glucose limits: 1.6/40 mmol / 15/720 mg/dl
* Clean up input sanitation to still clear dialog but in a nicer way
    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    fbd7587 View commit details
    Browse the repository at this point in the history

  9. Fix typo for glucose limit unit

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    547217d View commit details
    Browse the repository at this point in the history

  10. Change limits to 0.8/40 <-> 14/720 mg/dl

    @dnzxy
    dnzxy committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    12b9016 View commit details
    Browse the repository at this point in the history