Implement swipe-to-delete for history treatments + Change alerts #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bcedab850827602591f21caf9c04620a70c7a16e)
|
Added localisation code to your PR and new strings |
mountrcg
added a commit
to mountrcg/iAPS
that referenced
this pull request
Nov 20, 2023
…#314) Co-authored-by: Jon Mårtensson <jon.m@live.se>
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on existing behaviours for glucose history and introduces swipe-to-delete behaviour for history treatments. The work of this PR is based on a "poll" type question Discord (see here on Discord and the conversation that evolved from here).
Contents
<formatted timestamp>, <item amount text>To avoid a certain UI glitch, the swipe-to-delete was altered and now uses custom
.swipeActionsand no longer SwiftUI's standardList.onDeletebehaviour. Deletion works exactly like before but the animation does no longer for the full row item, it stops at 50%. This fixes an apparent issue.The features introduced with this PR have been tested by @Marvout, @AndreasStokholm and myself. There is a bug around deleted insulin entries that originates from Loop which has been documented with issue #305 and does not originate or affect any of the features or behaviours this PR introduces.
UI Look & Feel
Disclaimer: the big gray circle you see is from making screenshots for a swipe gesture in a simulator. This is not really visible to the user on a real phone.