Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German translation #26

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Add German translation #26

merged 1 commit into from
Jan 20, 2024

Conversation

daPhipz
Copy link
Contributor

@daPhipz daPhipz commented Jan 20, 2024

I edited the README since I could not find an Italian translation anywhere. This German translation is not complete, but it's a good starting point I guess...

Feel free to ping me whenever there are new strings to translate!

@ljuzig ljuzig merged commit 54e5627 into AstraExt:main Jan 20, 2024
@ljuzig
Copy link
Collaborator

ljuzig commented Jan 20, 2024

Hi, many thanks for the German translation, great job! The Italian translation had been temporarily removed a few versions ago, I will add it back shortly! The scripts and translation support were very sketchy and running them could mess up, now they should be ok and usable. I'll merge the pull request now, thanks again!

@ljuzig
Copy link
Collaborator

ljuzig commented Jan 20, 2024

I suggest you to shorten this one next time:

#: src/memory/memoryMenu.js:248 src/memory/memoryMenu.js:470
msgid "Cached"
msgstr "Zwischengespeicherte Suchdaten lösche"

cuz it appears in the context menu and should be as short as possible:

image

@ljuzig
Copy link
Collaborator

ljuzig commented Jan 20, 2024

also these ones needed maybe more context and explanation, I will add it to the msgctxt:

#: prefs.js:507
msgid "Celsius"
msgstr "Celsius und Fahrenheit bei Temperatursensoren hinzugefügt"

#: prefs.js:508
msgid "Fahrenheit"
msgstr "Celsius"

They actually are the content of this dropdown:

image

@daPhipz
Copy link
Contributor Author

daPhipz commented Jan 20, 2024

Oops, my bad - these should be fuzzy! I used Poedit's feature to pre-translate strings, I guess this slipped through and was not marked as fuzzy.
I will check the translation when I have the time, maybe tomorrow. Sorry!

@daPhipz daPhipz mentioned this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants